Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSV file handling in WorkingWithFiles #94

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

vspenubarthi
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@davidmascharka davidmascharka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
Python/Module5_OddsAndEnds/WorkingWithFiles.md Outdated Show resolved Hide resolved
@vspenubarthi
Copy link
Collaborator Author

@rsokl @davidmascharka I know that this is ... a bit late but I was hoping one of you could re-review this. Some students of mine were asking about parsing CSVs and I was like "there's a PLYMI section on that" :) Oops.

Copy link
Collaborator

@davidmascharka davidmascharka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all just minor comments. I think this is alright. I feel like it could be fleshed out more but I'm also not sure what I'd want to see in addition so maybe we can punt improvements until later....

@vspenubarthi
Copy link
Collaborator Author

@davidmascharka All minor updates have been committed. Should I attempt to fix the merge conflict? Or is that something you or Ryan would do from your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants