Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more: print more context if we preempt in atomic section #389

Merged
merged 1 commit into from
Mar 6, 2025
Merged

more: print more context if we preempt in atomic section #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions util/fibers/detail/scheduler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,17 @@ ctx::fiber_context Scheduler::Preempt() {
if (FiberActive() == dispatch_cntx_.get()) {
LOG(DFATAL) << "Should not preempt dispatcher: " << GetStacktrace();
}
if (IsFiberAtomicSection())
LOG(DFATAL) << "Preempting inside of atomic section";

if (IsFiberAtomicSection()) {
static int64_t last_ts = 0;
int64_t now = time(nullptr);
if (now != last_ts) { // once a second at most.
last_ts = now;
Comment on lines +208 to +211
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you remove the LEGACY_GLOG support in favor of absl logs, you can replace this with a simple LOG_EVERY_N_SEC(DFATAL, 1), but I guess not yet 😞

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this does not work and I won't have time to complete all the logging functionality with absl.
they do not support log files out of the box and other stuff as well. Could be a nice feature contribution to helio ;)

LOG(DFATAL) << "Preempting inside of atomic section, fiber: " << FiberActive()->name()
<< ", stacktrace:\n" << GetStacktrace();
}
}

DCHECK(!ready_queue_.empty()); // dispatcher fiber is always in the ready queue.

FiberInterface* fi = &ready_queue_.front();
Expand Down Expand Up @@ -457,7 +466,6 @@ void Scheduler::PrintAllFiberStackTraces() {
add_time = false;
}


string print_cb_str;
#ifndef NDEBUG
print_cb_str = fb->stacktrace_print_cb_ ? fb->stacktrace_print_cb_() : string{};
Expand Down
Loading