more: print more context if we preempt in atomic section #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Gershman <[email protected]>
chakaz
reviewed
Mar 6, 2025
Comment on lines
+208
to
+211
| static int64_t last_ts = 0; | ||
| int64_t now = time(nullptr); | ||
| if (now != last_ts) { // once a second at most. | ||
| last_ts = now; |
There was a problem hiding this comment.
When you remove the LEGACY_GLOG support in favor of absl logs, you can replace this with a simple LOG_EVERY_N_SEC(DFATAL, 1), but I guess not yet 😞
There was a problem hiding this comment.
yeah this does not work and I won't have time to complete all the logging functionality with absl.
they do not support log files out of the box and other stuff as well. Could be a nice feature contribution to helio ;)
I see what you did there! 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.