Enable AVX-512BW and AVX-512DQ target features in AVX-512 dispatch #629
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AVX-512BW was tested for in `Avx512Isa::new`, but not enabled when dispatching. This resulted in intrinsics using these extensions not being inlined. - AVX-512DQ is used by `_mm512_xor_ps`, but this feature was not tested for and the target feature wasn't enabled, so this intrinsic did not get inlined. According to [^1] all CPUs that support the BW extension also support DQ, so this doesn't change which systems can use AVX-512. [^1]: https://en.wikipedia.org/wiki/Advanced_Vector_Extensions#AVX-512_CPU_compatibility_table
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVX-512BW was tested for in
Avx512Isa::new, but not enabled when dispatching. This resulted in intrinsics using these extensions not being inlined.AVX-512DQ is used by
_mm512_xor_ps, but this feature was not tested for and the target feature wasn't enabled, so this intrinsic did not get inlined.According to 1 all CPUs that support the BW extension also support DQ, so this doesn't change which systems can use AVX-512.
Footnotes
https://en.wikipedia.org/wiki/Advanced_Vector_Extensions#AVX-512_CPU_compatibility_table ↩