-
Notifications
You must be signed in to change notification settings - Fork 129
OLAP Connectors: Add DSN configuration option #6870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
definitely will need to look at revisiting |
Sounds good – just note that Druid & Pinot will have this DSN option too |
LGTM from an experience POV. One minor thing that I noticed(exists on main not introduced in this PR) is that if clickhouse modeling is disabled then I can't add one more clickhouse connection from UI. The |
Thanks, Anshul. Addressed this comment here: #6904 |
* Fix bug in connector explorer * Add alternate form for DSN * Add tests * Cleanup * Give the DSN form its own error state * Remove debug line * Add `waitForURL` to tests * Update locator * Use native Clickhouse protocol for placeholder
* Fix bug in connector explorer * Add alternate form for DSN * Add tests * Cleanup * Give the DSN form its own error state * Remove debug line * Add `waitForURL` to tests * Update locator * Use native Clickhouse protocol for placeholder
Closes #6579
Checklist: