-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OLAP Connectors: Test the connection before exiting the "Add Data" modal #6892
Open
ericpgreen2
wants to merge
16
commits into
main
Choose a base branch
from
olap-connector-test-connection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that a connection to the OLAP database is successfully established before finalizing the creation of a
connector.yaml
file and updating the.env
file. Previously, submitting the ClickHouse, Druid, or Pinot connector forms would create these files regardless of the validity of the credentials.Implementation details:
connector.yaml
file..env
file with the provided credentials.OLAPListTables
API to verify the connection..env
file, and display an error message.Once #6671 lands, we can potentially switch the implementation to use a
tmp
directory and, in particular, atmp/.env
file to test credentials.This PR builds on #6870, which should be reviewed first.
Checklist: