Configuration to scale Critical Capture odds based on local Pokedex or estimated National Pokedex

[surskitty]

If you are disabling a wide variety of species across generations, it is likely that most pokemon in the National Pokedex will be unobtainable, which means that it's undesirable behavior to scale the % chance that a Critical Capture will happen based off of the number of Pokemon in the national dex assuming all Pokémon were obtainable within that generation. This instead adds a configuration setting to change it to go by the number of Pokemon in the Hoenn Pokedex instead, as it's far easier to adjust what's in the Hoenn Pokedex than to account for disabled species in the National Pokedex.

Discord contact info

wildvenonat

[Bassoonian]

You'll want to target upcoming instead with this, haha

[surskitty]

Oops! That's fixed now :)

[pkmnsnfrn]

@surskitty do you have any artifact showing that this works in game? even a debug print for each of the states showing the odds changing would be great

[surskitty]

@surskitty do you have any artifact showing that this works in game? even a debug print for each of the states showing the odds changing would be great

I checked a few of the thresholds that should have given me different odds and they appeared to be functioning correctly, at least. I no longer have record for a few of them because I hadn't taken into account the overall catching odds so the critical capture rates were a flat number, but they were 0 in the correct ballparks for nationaldex up to gen 9 and not-zero in the correct ballparks for hoenndex. Hoenndex stops being 0 at around 10 caught, and gen 9 nationaldex at around 48 (which is what the expansion already does).

[INFO] GBA Debug: Overall catching odds are 243
[INFO] GBA Debug: With 50 caught and totalDexCount 1025, total critical capture odds are 20

[INFO] GBA Debug: Overall catching odds are 244
[INFO] GBA Debug: With 50 caught and totalDexCount 215, total critical capture odds are 40

As far as I'm aware there isn't much known data for canon thresholds based on dex size and the critical capture rates in the expansion are extrapolated to begin with, hehe.