Skip to content

update the registry to point to new proxy endpoint #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update the registry to point to new proxy endpoint #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ restartPolicy: Always
# Replicated SDK image properties
# If .Values.images is set, it takes precedence over the following settings.
image:
registry: registry.replicated.com # Registry where the image is hosted
registry: proxy.replicated.com # Registry where the image is hosted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is probably the most important one. This is the seed for the template.

repository: "library/replicated-sdk-image" # Image repository
tag: "1.0.0" # Image tag, replaced in our pipeline
pullPolicy: IfNotPresent # Image pull policy: Always, IfNotPresent, Never
Expand Down
2 changes: 1 addition & 1 deletion dagger/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func buildAndPushChartToTTL(
return "", err
}

valuesYAML = strings.Replace(valuesYAML, "registry: registry.replicated.com", fmt.Sprintf("registry: %s", imageRegistry), 1)
valuesYAML = strings.Replace(valuesYAML, "registry: proxy.replicated.com", fmt.Sprintf("registry: %s", imageRegistry), 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one that comes into play during the validate dagger cal (and the validate ci step). buildAndPushChartToTTL will get called with a imageRegistry val passed to it by the result of buildAndPushImageToTTL which has ttl.sh hard coded:

replicated-sdk/dagger/build.go

Line 28 in b33008f

return "ttl.sh", fmt.Sprintf("automated-%s/replicated-image/replicated-sdk", now), "24h", nil

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just random notes for all of us)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed like it is here.

valuesYAML = strings.Replace(valuesYAML, `repository: "library/replicated-sdk-image"`, fmt.Sprintf(`repository: "%s"`, imageRepository), 1)
valuesYAML = strings.Replace(valuesYAML, `tag: "1.0.0"`, fmt.Sprintf(`tag: "%s"`, imageTag), 1)

Expand Down
2 changes: 1 addition & 1 deletion dagger/chart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func buildAndPublishChart(
}

if staging {
valuesYaml = strings.Replace(valuesYaml, `registry: registry.replicated.com`, `registry: registry.staging.replicated.com`, 1)
valuesYaml = strings.Replace(valuesYaml, `registry: proxy.replicated.com`, `registry: proxy.staging.replicated.com`, 1)

username := mustGetNonSensitiveSecret(ctx, opServiceAccount, "Replicated SDK Publish", "library_username", VaultDeveloperAutomationProduction)
password := mustGetSecret(ctx, opServiceAccount, "Replicated SDK Publish", "staging_library_password", VaultDeveloperAutomationProduction)
Expand Down
Loading