update the registry to point to new proxy endpoint #283
Conversation
staciegravy
force-pushed
the
staciegraves/sc-123590/update-sdk-to-pull-from-new-registry-proxy
branch
2 times, most recently
from
29f8e0a to
f2f8fd9
Compare
| @@ -31,7 +31,7 @@ restartPolicy: Always | |||
| # Replicated SDK image properties | |||
| # If .Values.images is set, it takes precedence over the following settings. | |||
| image: | |||
| registry: registry.replicated.com # Registry where the image is hosted | |||
| registry: proxy.replicated.com # Registry where the image is hosted | |||
There was a problem hiding this comment.
👍 this is probably the most important one. This is the seed for the template.
| @@ -41,7 +41,7 @@ func buildAndPushChartToTTL( | |||
| return "", err | |||
| } | |||
|
|
|||
| valuesYAML = strings.Replace(valuesYAML, "registry: registry.replicated.com", fmt.Sprintf("registry: %s", imageRegistry), 1) | |||
| valuesYAML = strings.Replace(valuesYAML, "registry: proxy.replicated.com", fmt.Sprintf("registry: %s", imageRegistry), 1) | |||
There was a problem hiding this comment.
This is the one that comes into play during the validate dagger cal (and the validate ci step). buildAndPushChartToTTL will get called with a imageRegistry val passed to it by the result of buildAndPushImageToTTL which has ttl.sh hard coded:
replicated-sdk/dagger/build.go
Line 28 in b33008f
There was a problem hiding this comment.
(just random notes for all of us)
There was a problem hiding this comment.
This needs to be changed like it is here.
dagger/chainguard.go
Outdated
| @@ -307,7 +307,7 @@ func publishChainguardImage( | |||
| env := "dev" | |||
| if strings.Contains(imagePath, "registry.staging.replicated.com") { | |||
| env = "stage" | |||
| } else if strings.Contains(imagePath, "registry.replicated.com") { | |||
| } else if strings.Contains(imagePath, "registry.replicated.com") || strings.Contains(imagePath, "proxy.replicated.com") { | |||
There was a problem hiding this comment.
I think this will actually never be the proxy? Because i think its always going to want to operate on the published image - not the proxied version. its gonna be the 3 images in publish.go ala -
replicated-sdk/dagger/publish.go
Line 109 in b33008f
staciegravy
force-pushed
the
staciegraves/sc-123590/update-sdk-to-pull-from-new-registry-proxy
branch
from
7f12251 to
a3d76aa
Compare
What does this PR do?
Update the registry to point to the new proxy endpoint.
Does this PR introduce a user-facing change?