remove rapids-get-pr-{conda,wheel}-artifact #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
breaking
This was referenced Aug 5, 2025
jameslamb
changed the title
|
This is working! See "How I tested this" in the description, specifically rapidsai/cudf#19593 (comment) |
jameslamb
commented
Aug 5, 2025
|
From the search results in your PR body, I did see this result, which may need to be updated: https://github.com/rapidsai/graph_dl/blob/25df0db6c390f35308c7d3e0276eaf48396cd878/scripts/get_ci_artifacts.sh#L118 |
ajschmidt8
approved these changes
Aug 7, 2025
|
Thanks for double-checking! Yep I already have a PR up for that: https://github.com/rapidsai/graph_dl/pull/822 And it's fine to merge this without waiting on that to be merged... I don't think there's anything automated using that repo, so they can pin back to an older |
|
Merging this now that the corresponding docs change is merged: rapidsai/docs#653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #145
rapids-get-pr-conda-artifactandrapids-get-pr-wheel-artifact_rapids-get-pr-artifacttorapids-get-pr-artifactNotes for Reviewers
Is this safe to merge?
Yes, these things are only used for testing purposes in PRs, as described in https://docs.rapids.ai/resources/github-actions/#using-conda-ci-artifacts-in-other-prs
Merging this shouldn't break CI for any projects. GitHub search with evidence of that: https://github.com/search?q=org%3Arapidsai+%22rapids-get-pr%22+AND+NOT+is%3Aarchived&type=code
How I tested this
Opened an
rmmPR (rapidsai/rmm#2008) and tested that the docs as of rapidsai/docs#653 worked on acudfPR (rapidsai/cudf#19593 (comment)).