Avoid setting fixed app name in console prompt #51732
Merged
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
IRB allows changing its prompt's name during the session, like:
But because I previously set the app name as part of the prompt, instead of via the
irb_name
config, such change can't happen in a Rails console:This can be problematic as tools/features can rely on the name change to indicate state change (example).
Detail
Instead of setting app name as a fixed value in prompt, I replaced it with
%N
, which IRB uses to display theirb_name
attribute. And then we can set assign the app name toIRB.conf[:IRB_NAME]
(default is"irb"
).Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]