-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RF-DOCS] Active Record Callbacks #51654
Open
Ridhwana
wants to merge
91
commits into
rails:main
Choose a base branch
from
Ridhwana:Ridhwana/active-record-callbacks-documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[RF-DOCS] Active Record Callbacks #51654
Ridhwana
wants to merge
91
commits into
rails:main
from
Ridhwana:Ridhwana/active-record-callbacks-documentation
+948
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
p8
reviewed
Jun 7, 2024
NOTE: If an `ActiveRecord::RecordNotDestroyed` is raised within `after_destroy`, `before_destroy` or `around_destroy` callback, it will not be re-raised and the `destroy` method will return `false`. | ||
NOTE: If an `ActiveRecord::RecordNotDestroyed` is raised within `after_destroy`, | ||
`before_destroy` or `around_destroy` callback, it will not be re-raised and the | ||
`destroy` method will return `false`. | ||
|
||
Relational Callbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "Cascading Association Callbacks" is a great title.
These changes are really nice.
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Co-authored-by: Petrik de Heus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created to provide more clarity and update the Active Record Callbacks documentation.
Detail
This guide has probably been reviewed multiple times over time, so we can do a quick pass to see where we can make things clearer, simpler, and/or more concise.
Some initial thoughts to get started:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]