Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-2743] Create basic UI for bottom sheet to access factor sources #750

Merged
merged 42 commits into from
Feb 14, 2024
Merged

[ABW-2743] Create basic UI for bottom sheet to access factor sources #750

merged 42 commits into from
Feb 14, 2024

Commits on Feb 9, 2024

  1. make currentNetwork not nullable and default to default network

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3ffca05 View commit details
    Browse the repository at this point in the history

  2. removed unnecessary ExperimentalAnimationApi

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6a8d421 View commit details
    Browse the repository at this point in the history

  3. added access factor source feature package in presentation which 

    contains basic screen, viewmodel, and its navgraph
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    998b223 View commit details
    Browse the repository at this point in the history

  4. added accessFactorSourceBottomSheet in NavigationHost

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2767c95 View commit details
    Browse the repository at this point in the history

  5. added app events to trigger bottom sheet

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1744b6c View commit details
    Browse the repository at this point in the history

  6. added icon create account

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f993bd6 View commit details
    Browse the repository at this point in the history

  7. reverted nullable currentNetwork from profile extensions

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    19ded08 View commit details
    Browse the repository at this point in the history

  8. removed all ExperimentalAnimationApi

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    59c9483 View commit details
    Browse the repository at this point in the history

  9. renamed every AccessFactorSource to AccessFactorSources

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    fe840c4 View commit details
    Browse the repository at this point in the history

  10. fixed detekt

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    feed700 View commit details
    Browse the repository at this point in the history

  11. make LedgerHardwareWalletFactorSource and DeviceFactorSource able to 

    create accounts with an interface
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    96af5cc View commit details
    Browse the repository at this point in the history

  12. added CreateAccountExtensions and replaced them in use cases of 

    the profile module and update ProfileGenerationTest
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    849f61d View commit details
    Browse the repository at this point in the history

  13. added AccessFactorSourceProvider that provides access to factor sources

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    28ba9f3 View commit details
    Browse the repository at this point in the history

  14. added new CreateAccountUseCase which takes a CreateEntity factor source 

    and its unit test
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c2cb59d View commit details
    Browse the repository at this point in the history

  15. updated ChooseLedgerScreen to only return the selected ledger and 

    not to derive public key from it
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    53bf3c8 View commit details
    Browse the repository at this point in the history

  16. added AccessFactorSourceProxyContract

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    db5d211 View commit details
    Browse the repository at this point in the history

  17. added implementation of AccessFactorSourceProxy

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    46d8378 View commit details
    Browse the repository at this point in the history

  18. refactored CreateAccount screen to use the AccessFactorSourceProxy and 

    the new CreateAccountUseCase
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    cb41e6e View commit details
    Browse the repository at this point in the history

  19. implemented logic for AccessFactorSourceBottomSheet and its viewmodel

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e44f280 View commit details
    Browse the repository at this point in the history

  20. removed old use cases to create account

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    3867ecb View commit details
    Browse the repository at this point in the history

  21. removed wrong interface from AccessFactorSourceProxyImpl

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    248935a View commit details
    Browse the repository at this point in the history

  22. renamed ViewModule to UiModule

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    820d84e View commit details
    Browse the repository at this point in the history

  23. renamed every AccessFactorSource to AccessFactorSources

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    94a4293 View commit details
    Browse the repository at this point in the history

  24. fixed detekt

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    167c2d6 View commit details
    Browse the repository at this point in the history

  25. fixed unit test ChooseLedgerViewModelTest

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    86d2010 View commit details
    Browse the repository at this point in the history

  26. renamed app event ToCreateAccount to DeriveAccountPublicKeys

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1e6eab7 View commit details
    Browse the repository at this point in the history

  27. refactored AccessFactorSourcesProxyContract to return failure

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f26f3f3 View commit details
    Browse the repository at this point in the history

  28. renamed LedgerSelectionPurpose CreateAccount to DerivePublicKey

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    725dfa0 View commit details
    Browse the repository at this point in the history

  29. do not ensureBabylonFactorSourceExistUseCase in ChooseLedgerViewModel 

    when purpose is to derive public key
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    8df6a48 View commit details
    Browse the repository at this point in the history

  30. ensureBabylonFactorSourceExistUseCase when derive public key in 

    AccessFactorSourcesViewModel
    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    41783dd View commit details
    Browse the repository at this point in the history

  31. one off event for biometric prompt in AccessFactorSourcesViewModel

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ff2236e View commit details
    Browse the repository at this point in the history

  32. next line

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    373fb44 View commit details
    Browse the repository at this point in the history

  33. better naming

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    253abe0 View commit details
    Browse the repository at this point in the history

  34. fixed naming

    @giannis-rdx
    giannis-rdx committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    fb12bc4 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. removed unnecessary val ledger in DeriveAccountPublicKey app event

    @giannis-rdx
    giannis-rdx committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e03ef9d View commit details
    Browse the repository at this point in the history

  2. better names for AccessFactorSources functions

    @giannis-rdx
    giannis-rdx committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c7dbac7 View commit details
    Browse the repository at this point in the history

  3. minor

    @giannis-rdx
    giannis-rdx committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    73924e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. fixed detekt

    @giannis-rdx
    giannis-rdx committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7fc3927 View commit details
    Browse the repository at this point in the history

  2. removed unnecessary public reset

    @giannis-rdx
    giannis-rdx committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    70b53d7 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #761 from radixdlt/feature/ABW-2744-access-factor-… 

    …sources-create-accounts

[ABW-2744] Access factor sources refactoring - create accounts
    @giannis-rdx
    giannis-rdx authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    115fc02 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. updated AccessFactorSourcesDialog UI

    @giannis-rdx
    giannis-rdx committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    570c5df View commit details
    Browse the repository at this point in the history

  2. fixed detekt

    @giannis-rdx
    giannis-rdx committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7de83ed View commit details
    Browse the repository at this point in the history