[ABW-2743] Create basic UI for bottom sheet to access factor sources #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giannis-rdx
changed the title
giannis-rdx
force-pushed
the
task/refactor-current-network-not-nullable
branch
from
03fa8d1
to
3da3bed
Compare
giannis-rdx
changed the base branch from
task/refactor-current-network-not-nullable
to
main
giannis-rdx
force-pushed
the
feature/ABW-2743-create-basic-ui-for-bottom-sheet
branch
from
7f89447
to
92399bf
Compare
giannis-rdx
changed the title
giannis-rdx
force-pushed
the
feature/ABW-2743-create-basic-ui-for-bottom-sheet
branch
from
39212ed
to
7dbd00a
Compare
2 tasks
micbakos-rdx
approved these changes
Jan 24, 2024
| @@ -87,6 +87,10 @@ class MainViewModel @Inject constructor( | |||
| .events | |||
| .filterIsInstance<AppEvent.Status>() | |||
|
|
|||
| val accessFactorSourceEvents = appEventBus | |||
| .events | |||
| .filterIsInstance<AppEvent.AccessFactorSource.ToCreateAccount>() | |||
There was a problem hiding this comment.
Maybe .filterIsInstance<AppEvent.AccessFactorSource>() ?
I am always open for better names!! |
raf-rdx
reviewed
Jan 24, 2024
| ) { | ||
| BottomSheetDialogWrapper( | ||
| modifier = modifier, | ||
| onDismiss = { |
There was a problem hiding this comment.
lambda not needed here ? can be just onDismiss = onDismiss
There was a problem hiding this comment.
true. will change in the next PR
raf-rdx
approved these changes
Jan 24, 2024
giannis-rdx
force-pushed
the
feature/ABW-2743-create-basic-ui-for-bottom-sheet
branch
from
af736ef
to
688feb7
Compare
jakub-rdx
approved these changes
Jan 29, 2024
| ) { | ||
| Text( | ||
| style = RadixTheme.typography.title, | ||
| text = stringResource(id = R.string.derivePublicKeys_titleCreateAccount) |
There was a problem hiding this comment.
this will be parametrized to reflect use context of the dialog?
giannis-rdx
force-pushed
the
feature/ABW-2743-create-basic-ui-for-bottom-sheet
branch
2 times, most recently
from
5376eb4
to
e525b75
Compare
contains basic screen, viewmodel, and its navgraph
the new CreateAccountUseCase
when purpose is to derive public key
AccessFactorSourcesViewModel
…sources-create-accounts [ABW-2744] Access factor sources refactoring - create accounts
|
giannis-rdx
deleted the
feature/ABW-2743-create-basic-ui-for-bottom-sheet
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first PR of the ABW-2743 ticket and contains
HandleStatusEventsAnother chained PR will follow. The next PR will contain logic for the
How to test
No need to test. The app should run as expected.
Screenshot
In the next PR
PR submission checklist