feat!: various debounce improvements (DO NOT SQUASH) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
feat/debounce-handler
branch
from
d3f076c to
1de9de9
Compare
3 tasks
aleclarson
force-pushed
the
feat/debounce-handler
branch
from
10a9794 to
b100467
Compare
aleclarson
force-pushed
the
feat/debounce-handler
branch
from
b100467 to
586b258
Compare
aleclarson
changed the title
adamhamlin
reviewed
Jul 14, 2024
Comment on lines
+31
to
+36
| * Debounced functions have these methods: | ||
| * | ||
| * - The `cancel` method cancels the debounced function. | ||
| * - The `flush` method calls the underlying function immediately if it was | ||
| * debounced, otherwise it does nothing. | ||
| * - The `isPending` method checks if the debounced function is pending. |
There was a problem hiding this comment.
Include handler here? I assume you're publicly exposing it since flush no longer guarantees execution?
Add to the docs as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
cancelis called. Previously,cancelwould disable debouncing, so future calls would be immediate.flushcall the underlying function if no call is pending.handlerproperty.Related issue, if any:
Resolves #105
Resolves sodiray/radash#362
For any code change,
Does this PR introduce a breaking change?
Yes
Bundle impact
src/curry/debounce.ts