fix: debounce
cancel() should clear pending timeout
#108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
This PR changes the behavior of a debounced function's
cancel()
method:BEFORE: Calling
cancel()
preempts any pending invocation and permanently makes all future invocations execute immediately (i.e., not be debounced)AFTER: Calling
cancel()
cancels/clears any pending invocation. Subsequent invocations are debounced as normal.Related issue, if any:
Closes #105
For any code change,
Does this PR introduce a breaking change?
Yes
@aleclarson sounds like we're considering this a "bug", so not sure we'd do anything other than make a note in release notes? Please advise
Bundle impact
Calculating...