Extract shared PileupColumn validity check#1392
Draft
nh13 wants to merge 1 commit intopysam-developers:masterfrom
Draft
Extract shared PileupColumn validity check#1392nh13 wants to merge 1 commit intopysam-developers:masterfrom
nh13 wants to merge 1 commit intopysam-developers:masterfrom
Conversation
nh13
force-pushed
the
nh13/consolidate-pileup-iteration
branch
from
73d61ce to
680a8ff
Compare
nh13
changed the title
nh13
force-pushed
the
nh13/consolidate-pileup-iteration
branch
from
680a8ff to
2714682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_pileup_valid()cdef helper onPileupColumnthat raisesValueErrorif the pileup buffer is NULL (iterator exhausted)get_query_qualities()(fixing the same bug as PR Add missing NULL guard in PileupColumn.get_query_qualities #1380 but structurally)Test plan
REF_PATH=: pytest tests/AlignmentFilePileup_test.py -vAI disclosure: This PR was AI-assisted using Claude Code. The issue was identified via AI-guided code review, and the implementation was drafted by AI with human review and approval.