Support value_type of 'B' in get_tag_typecode()#1365
Open
bentyeh wants to merge 1 commit intopysam-developers:masterfrom
Open
Support value_type of 'B' in get_tag_typecode()#1365bentyeh wants to merge 1 commit intopysam-developers:masterfrom
bentyeh wants to merge 1 commit intopysam-developers:masterfrom
Conversation
# Context
If a user calls `set_tag(tag, value, value_type)` where `value_type='B'`, then the following error is raised:
```
ValueError('unsupported value_type {} in set_option'.format(typecode))
```
---------------
# Bug
Line 2512 of libcalignedsegment.pyx in the `set_tag()` function calls `get_tag_typecode(value, value_type)`.
In its current implementation, `get_tag_typecode` will always return a value of 0 (indicating an unknown type) if `value_type` is `'B'` due to `'B'` missing from the enumerated types in line 244:
```
if value_type in 'aAsSIcCZidfH':
typecode = force_bytes(value_type)[0]
```
Back in `set_tag()`, this typecode value of 0 triggers the ValueError.
-------------------
# Solution
Add `'B'` to the enumerated types in `get_tag_typecode()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
If a user calls
set_tag(tag, value, value_type)wherevalue_type='B', then the following error is raised:This corresponds to issue #1108.
Bug
Line 2512 of libcalignedsegment.pyx in the
set_tag()function callsget_tag_typecode(value, value_type).In its current implementation,
get_tag_typecodewill always return a value of 0 (indicating an unknown type) ifvalue_typeis'B'due to'B'missing from the enumerated types:pysam/pysam/libcalignedsegment.pyx
Lines 244 to 245 in 2f9d50d
Back in
set_tag(), this typecode value of 0 triggers the ValueError.Solution
Add
'B'to the enumerated types inget_tag_typecode().