Skip to content

Fix hook deps not being installed #2225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cobaltt7 wants to merge 4 commits into
base: master
Choose a base branch
from
+4 −2
Open

Fix hook deps not being installed #2225

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb5dea7
Fix hook deps not being installed
cobaltt7 Mar 29, 2026
1eec9c2
Move the `prepare_environment` call to before dependency synchronization
cobaltt7 Apr 6, 2026
db09258
Merge branch 'master' into gh-2110-2139
cobaltt7 Apr 6, 2026
efe7994
empty commit to retrigger ci
cobaltt7 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hatch/project/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ def prepare_build_environment(self, *, targets: list[str] | None = None, keep_en
except Exception as e: # noqa: BLE001
self.app.abort(f"Environment `{self.build_env.name}` is incompatible: {e}")

self.prepare_environment(self.build_env, keep_env=keep_env)

additional_dependencies: list[str] = []
with self.app.status("Inspecting build dependencies"):
if build_backend != BUILD_BACKEND:
Expand All @@ -290,6 +288,8 @@ def prepare_build_environment(self, *, targets: list[str] | None = None, keep_en
with self.build_env.app_status_dependency_synchronization():
self.build_env.sync_dependencies()

self.prepare_environment(self.build_env, keep_env=keep_env)
Copy link
Copy Markdown
Member

@cjames23 cjames23 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be before the context manager that handles dependency synchronization most likely.

Copy link
Copy Markdown
Author

@cobaltt7 cobaltt7 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I don't think the first if additional_dependencies is necessary still, but I kept it in case of any potential performance benefits (I'm unaware if there actually are any)


def get_dependencies(self) -> tuple[list[str], dict[str, list[str]]]:
dynamic_fields = {"dependencies", "optional-dependencies"}
if not dynamic_fields.intersection(self.metadata.dynamic):
Expand Down
Loading