Open
Conversation
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
cjames23
reviewed
Mar 30, 2026
| with self.build_env.app_status_dependency_synchronization(): | ||
| self.build_env.sync_dependencies() | ||
|
|
||
| self.prepare_environment(self.build_env, keep_env=keep_env) |
Member
There was a problem hiding this comment.
This should be before the context manager that handles dependency synchronization most likely.
Author
There was a problem hiding this comment.
Done. I don't think the first if additional_dependencies is necessary still, but I kept it in case of any potential performance benefits (I'm unaware if there actually are any)
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2139
Fixes #2110
Superseeds & closes #2206
I didn't notice #2206 had been raised until after I had finished manually debugging myself, but thought I might as well open my own PR. This is an alternate fix to #2206 that retains the performance benefits of using
cached_property.The issue was that
additional_dependencieshadn't been found yet whenprepare_environmentwas called, so they didn't end up in the cachedall_dependencies_complex. I fixed the issue by moving theprepare_environmentcall to afteradditional_dependenciesis set.I would greatly appreciate it if this is merged & released soon, as I'm sure many others would be too, as this is blocking me from upgating beyond hatch 1.15.1 (and by extension, beyond virtualenv 20.39.1).
I'd appreciate guidance creating tests if they're desired. I'm not sure what the best way to go about it is - the other PR linked seems to do it a bit roundabout by creating temp dirs
(No AI was used with this PR)