fix: require-runtime-dependencies not installed in build environment#2206
Open
psyclaudeZ wants to merge 1 commit intopypa:masterfrom
Open
fix: require-runtime-dependencies not installed in build environment#2206psyclaudeZ wants to merge 1 commit intopypa:masterfrom
require-runtime-dependencies not installed in build environment#2206psyclaudeZ wants to merge 1 commit intopypa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressing #2110.
Mentioned in the issue, #2073 changed
prepare_build_environmentsuch that:prepare_environmentsyncs the build env, cachingdependencies_complex,all_dependencies_complex, andmissing_dependenciesvia@cached_property.additional_dependenciessync_dependenciesagain but the cached properties from step 1 still have emptyadditional_dependenciesso runtime deps are never installed.This PR replaces
@cached_propertywith@propertyfor those fields. Alternatively, we could manually evict the fields after mutatingadditional_dependencies. However, I personally feel the latter is too ad-hoc and bypasses a more serious issue (caching properties that depend on mutable state).Test Plan
Disclaimer: I used Claude Code for these. TDD: