[spelling checker] Use a context manager to access the private dict

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Follow-up to #6491, before #6137

[coveralls]

Pull Request Test Coverage Report for Build 2264351021

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.005%) to 95.177%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pylint/checkers/spelling.py	0	3	0.0%

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/spelling.py	2	77.01%

Totals
Change from base Build 2264081008:	0.005%
Covered Lines:	15828
Relevant Lines:	16630

---

💛 - Coveralls

[Pierre-Sassoulas]

Safe to do because:

>>> import os
>>> os.path.expanduser("")
''

[DanielNoord]

Is there a direct need for self.private_dict_path? It seems like we could use self.linter.config.spelling_private_dict_file directly. The only difficulty is that we would need to do os.path.expanduser when loading the argument. So we would need a new argument type (probably called path).

[DanielNoord]

Suggested change

	def __init__(self, linter: PyLinter):
	def __init__(self, linter: PyLinter) -> None:

[Pierre-Sassoulas]

The only difficulty is that we would need to do os.path.expanduser when loading the argument. So we would need a new argument type (probably called path).

Having a generic path option that would make ALL options using a path, expand the user path correctly would be a huge win for pylint. There's 7 expandusers call in the codebase, but probably a lot of option where we do not support this yet.

[DanielNoord]

Having a generic path option that would make ALL options using a path, expand the user path correctly would be a huge win for pylint. There's 7 expandusers call in the codebase, but probably a lot of option where we do not support this yet.

Shouldn't be too difficult to create a new transformer. Do you want to look into this?

[Pierre-Sassoulas]

Do you want to look into this?

Sure.

Regarding the other comment, using the configuration make for rather long unreadable variable name self.linter.config.spelling_private_dict_file, spelling is noise when we're in the spelling checker (but not when we're in the pylint configuration) so I supposed that creating a small var name specific to the checker would clarify the code.

[DanielNoord]

Do you want to look into this?

Sure.

Regarding the other comment, using the configuration make for rather long unreadable variable name self.linter.config.spelling_private_dict_file, spelling is noise when we're in the spelling checker (but not when we're in the pylint configuration) so I supposed that creating a small var name specific to the checker would clarify the code.

Hm, on the other hand decoupling a setting from the actual underlying setting could create other problems down the line. What if we have the per directory configuration enabled and the underlying Namespace changes? I'd be in favour of the long name (although I do agree it is a bit annoying).