Create a path type of argument that automatically expand user/var #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Enhancement ✨
Pierre-Sassoulas
commented
May 3, 2022
pylint/config/argument.py
Outdated
Comment on lines
89
to
91
| # We'd need to distinguish between input path that should exist and output path that do not | ||
| # if not os.path.exists(value): | ||
| # raise argparse.ArgumentTypeError(f"'{value}' is not a valid path is does not exists.") |
There was a problem hiding this comment.
@DanielNoord what do you think, is it worth it ?
There was a problem hiding this comment.
Probably not, as I can imagine we might also want to use this as an output path at some point. So then it not existing is not a problem.
I think the OSError should probably be caught in the checkers themselves.
Pull Request Test Coverage Report for Build 2263887299
💛 - Coveralls |
DanielNoord
requested changes
May 3, 2022
Co-authored-by: Daniël van Noord <[email protected]>
DanielNoord
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refactor prior to #6493, permitted by the migration to argparse. It could permit to expanduser in various pylint configuration / options, so it's a feature.