Small refactor in spelling checker #6491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
Pierre-Sassoulas
force-pushed
the
small-refactor-in-spelling-checker
branch
from
0320fac to
99e5703
Compare
Pull Request Test Coverage Report for Build 2262447303
💛 - Coveralls |
DanielNoord
requested changes
May 3, 2022
| if lower_cased_word not in self.unknown_words: | ||
| if ( | ||
| lower_cased_word not in self.unknown_words | ||
| and self.private_dict_file is not None |
There was a problem hiding this comment.
Isn't this a change in behaviour?
There was a problem hiding this comment.
If self.private_dict_file is None the write() call would crash pylint. It's never happening but you have to read the whole class workflow to realize that, and mypy can't. I'll do a follow-up refactor to initialize thing in the constructor where it should be clearer.
Pierre-Sassoulas
commented
May 3, 2022
| original_line = line | ||
| try: | ||
| initial_space = re.search(r"^[^\S]\s*", line).regs[0][1] | ||
| # The mypy warning is caught by the except statement | ||
| initial_space = re.search(r"^\s+", line).regs[0][1] # type: ignore[union-attr] |
There was a problem hiding this comment.
There's a simplification in the regex here on top of the mypy ignore. [^\S] is \s and \s\s* is \s+
Co-authored-by: Daniël van Noord <[email protected]>
'[^\S]' is '\s' and '\s\s*' is '\s+'
Co-authored-by: Daniël van Noord <[email protected]>
Pierre-Sassoulas
force-pushed
the
small-refactor-in-spelling-checker
branch
from
67a0378 to
f12d026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Refactor prior to #6137