-
Notifications
You must be signed in to change notification settings - Fork 83
Fix for issue #58 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Arjan Bink <[email protected]>
Hi, could the CI please be started again? (The failure seems unrelated to the committed code) |
Needs a rebase |
Signed-off-by: Arjan Bink <[email protected]>
@bluewww Merged in master |
I thought about this again, I think its best if we just now allow 8-bit and 16-bit accesses since the code is already in place and seems correct to me see #57 |
Hi @bluewww Fully agreed that that would be the ideal fix. I went down that path first and quickly realized that this is more work than I wanted to invest in this, so instead of adding (not officially required support for) byte and halfword accesses I chose to at least fix the bugs in the currently supported access types. Note that the debugger knows which access types are supported via sbcs (and not supporting all of them is allowed). The code for the byte enables is largely there, but also the wdata, rdata, and address lsb will need fixes to support byte and halfword accesses. |
Hi @bluewww and @Silabs-ArjanB, |
This merge request doesn't need to be merged bcs the including changes are already added to main. So I thought it can be closed to prevent misunderstanding. @bluewww |
Fix for #58
Signed-off-by: Arjan Bink [email protected]