Skip to content

Fix for issue #58 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Silabs-ArjanB
Copy link
Contributor

Fix for #58

  • Added bus error for non-supported sbaccess values
  • Corrected bus error code for non-supported sbaccess values
  • Added bus error for misaligned SBA access attempts

Signed-off-by: Arjan Bink [email protected]

@Silabs-ArjanB
Copy link
Contributor Author

Hi, could the CI please be started again? (The failure seems unrelated to the committed code)

@bluewww bluewww linked an issue Oct 26, 2020 that may be closed by this pull request
@bluewww bluewww self-requested a review October 26, 2020 16:09
@bluewww
Copy link
Collaborator

bluewww commented Oct 26, 2020

Needs a rebase

Signed-off-by: Arjan Bink <[email protected]>
@Silabs-ArjanB
Copy link
Contributor Author

@bluewww Merged in master

@bluewww
Copy link
Collaborator

bluewww commented Oct 28, 2020

I thought about this again, I think its best if we just now allow 8-bit and 16-bit accesses since the code is already in place and seems correct to me see #57

@Silabs-ArjanB
Copy link
Contributor Author

I thought about this again, I think its best if we just now allow 8-bit and 16-bit accesses since the code is already in place and seems correct to me see #57

Hi @bluewww Fully agreed that that would be the ideal fix. I went down that path first and quickly realized that this is more work than I wanted to invest in this, so instead of adding (not officially required support for) byte and halfword accesses I chose to at least fix the bugs in the currently supported access types. Note that the debugger knows which access types are supported via sbcs (and not supporting all of them is allowed). The code for the byte enables is largely there, but also the wdata, rdata, and address lsb will need fixes to support byte and halfword accesses.

@noytzach
Copy link

noytzach commented Jan 4, 2021

Hi @bluewww and @Silabs-ArjanB,
Please see #106, for adding 8b and 16b accesses

@omerguzelelectronicguy
Copy link

This merge request doesn't need to be merged bcs the including changes are already added to main. So I thought it can be closed to prevent misunderstanding. @bluewww

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants