Plotting Graphs using Chart.js

[IshaGupta18]

Here is the basic implementation of graph plotting!
fixes #19
@namangupta01 @jywarren what do you think?

[namangupta01]

This looks awesome!! Very well done. I just have one minor doubt, while selecting y-axis there should be some checking if that column can be selected because y-axis can only be number? or am I missing something?

[namangupta01]

I think this is dependent on #15 ?

[IshaGupta18]

Thanks a lot! And yes you are right, I did think about that, but I skipped that just for now. But that is very important. Would you like to handle that one?

…

On Fri, May 10, 2019, 10:04 PM Naman Gupta ***@***.***> wrote: This looks awesome!! Very well done. I just have one minor doubt, while selecting y-axis there should be some checking if that column can be selected because y-axis can only be number? or am I missing something? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ2WN7RP3V2Q55TSMMDPUWP3BANCNFSM4HMED3CQ> .

[IshaGupta18]

Yes, it covers that up as well, merging this will close #15 I believe

…

On Fri, May 10, 2019, 10:10 PM Naman Gupta ***@***.***> wrote: I think this is dependent on #15 <#15> ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZZCTGRZVI3ONAWHRP3PUWQONANCNFSM4HMED3CQ> .

[namangupta01]

How is the graph when we select a column with not all number values? For example column 1 in the above gif. Can you share the gif how it will look?

[namangupta01]

And also how it will look in multiple columns(column without numbers) on the y-axis. I think if it looks fine we can go with it. Can you share the gif?

[IshaGupta18]

With a non-numeric column, it would be empty, as expected:

[IshaGupta18]

With a mix of numeric and non-numeric, this is what it looks like:

[IshaGupta18]

Obviously, we will have to do some handling, but this is the basic functioning.

[namangupta01]

Also, I think we can have a separate button for update graph, rather than updating using csv upload button after the graph like Update Graph.

[namangupta01]

I think what you can do is that while processing and adding header you can check if that column is having not all numbers or not and then depending on that you put the checkbox? What do you say? It will solve our problem. Right?

[IshaGupta18]

Yes yes, that was just for a demo! Actually this is not how the page will look like. In the deisgn I have made, there are 3 tabs, 1 for upload, 2nd for column selection, 3rd for chart(s) display and export and other options

[namangupta01]

Oh Okay, so are you doing that checking in this pr. I think it won't take much time doing this. But it is up to you.

[IshaGupta18]

I think what you can do is that while processing and adding header you can check if that column is having not all numbers or not and then depending on that you put the checkbox? What do you say? It will solve our problem. Right?

Yes we can do that I think. Let's discuss all the problems and handle them with the best solutions! Also, I ave posted some solutions for export options in #17 , where we have to do some operations on the collected data. So we can probably club these error handlings and those together to maximize the speed of processing. What do you think?

[IshaGupta18]

Also, we can actually think of a proper update button. For that, we'll have to properly think of the UI part. Like an update button on the 3rd tab that could take the user back to the 2nd tab to change the columns. Something like that?

[namangupta01]

I think we can leave the exporting option for now and do later in the project.

[IshaGupta18]

Yeah sure! Would like to handle these cases by merging this and pulling the code?

[namangupta01]

For now, we are not focuing on ui. Just simple button for updating graph?

[IshaGupta18]

Sure, we can do that too

[IshaGupta18]

Although, that might not be very important for now, but it can be implemented!

[namangupta01]

And one suggestion, when you merge any pr, merge it using squash and merge. It will make one commit in the main branch.

[IshaGupta18]

Okay thanks for the tip!

…

On Fri, May 10, 2019, 10:35 PM Naman Gupta ***@***.***> wrote: And one suggestion, when you merge any pr, merge it using squash and merge. It will make one commit in the main branch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ7OROEDRN7XYVTSAMDPUWTMPANCNFSM4HMED3CQ> .

[IshaGupta18]

@jywarren what do you think about this?

…

On Fri, May 10, 2019, 10:55 PM Isha Gupta ***@***.***> wrote: Okay thanks for the tip! On Fri, May 10, 2019, 10:35 PM Naman Gupta ***@***.***> wrote: > And one suggestion, when you merge any pr, merge it using squash and > merge. It will make one commit in the main branch. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#18 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AJXHQZ7OROEDRN7XYVTSAMDPUWTMPANCNFSM4HMED3CQ> > . >

[IshaGupta18]

Okay so I have handled the issue of showing the checkboxes against the valid columns only:

Is this good to go @namangupta01 ? Also, I have displayed the whole table but the checkboxes are against only the valid columns. Do you think I should show only the valid columns and the checkboxes, which would reduce the size of the 2nd table since, in the first table, all columns are bring shown anyways? What do you think/

[IshaGupta18]

I would also request @SidharthBansal @gauravano @Souravirus to have a look at the progress for the project in this repo! Thanks a lot!

[IshaGupta18]

Okay! So here is one more feature: Graphing menu with different graph types:
@jywarren @namangupta01 kindly give your views on it! Thanks a lot!

[SidharthBansal]

Graphing menus are superb. Can we have colours introduced in it instead of grey colour always?
Superb Isha

[IshaGupta18]

Thank you so much! Absolutely, this is just the functional model, the entire designing of the UI and the graphs has to be tackled!

…

On Mon, May 13, 2019, 12:03 PM Sidharth Bansal ***@***.***> wrote: Graphing menus are superb. Can we have colours introduced in it instead of grey colour always? Superb Isha — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJXHQZ4XI4XBPQPOAJPFKK3PVEDSTANCNFSM4HMED3CQ> .

[jywarren]

I think this is looking great. I think there's a Bootstrap "table" style that gives some nice table padding, if you want to try that? This is so exciting, Isha and Naman!

…

On Mon, May 13, 2019 at 2:36 AM Isha Gupta ***@***.***> wrote: Thank you so much! Absolutely, this is just the functional model, the entire designing of the UI and the graphs has to be tackled! On Mon, May 13, 2019, 12:03 PM Sidharth Bansal ***@***.***> wrote: > Graphing menus are superb. Can we have colours introduced in it instead of > grey colour always? > Superb Isha > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #18 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AJXHQZ4XI4XBPQPOAJPFKK3PVEDSTANCNFSM4HMED3CQ > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J3SAXS6VB72IMOLZY3PVED6HANCNFSM4HMED3CQ> .

[IshaGupta18]

Thanks a lot! We will be designing the UI as per the designed proposed in my proposal. I hope the working is okay so that I can proceed with the design!

[IshaGupta18]

Okay so the color scheme has been designed!

[IshaGupta18]

@jywarren @namangupta01 what do you think of this?

[IshaGupta18]

And also I am working on the UI for this file now, so I think it would be better if we can merge this pretty big PR now. What do you say?

[jywarren]

oh wow. If Naman is cool with it then go ahead and merge!

…

On Tue, May 14, 2019 at 12:56 PM Isha Gupta ***@***.***> wrote: And also I am working on the UI for this file now, so I think it would be better if we can merge this pretty big PR now. What do you say? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AAAF6JY7NTZFPFUGORNGO5LPVLVIBA5CNFSM4HMED3C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMDQPA#issuecomment-492320828>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6JYUL5YXI6XRQIDXQI3PVLVIBANCNFSM4HMED3CQ> .

[namangupta01]

Nice work @IshaGupta18! Looks good to me. Let get this merge!

[SidharthBansal]

Awesome folks

…

On Tue, May 14, 2019 at 11:35 PM Naman Gupta ***@***.***> wrote: Merged #18 <#18> into main. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18?email_source=notifications&email_token=AFAAEQYZ5PDBCRHCF2PKUZDPVL5PNA5CNFSM4HMED3C2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOROEJWUA#event-2340985680>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQ7RPQIOPKL6JCYXC5TPVL5PNANCNFSM4HMED3CQ> .