Sample data generation and table display #15
Conversation
|
Have opened an issue #14, have a look at it. |
|
This looks good. |
|
Why not x-axis can have multiple selections? |
|
Because on the x-axis we have a single set of labels right? And on the y
axis we can have multiple columns corresponding to those labels. Like days
on the x axis and say temperatures for each day on y. Graphs are mostly of
these types as far as I have seen. What do you think?
…On Thu, May 9, 2019, 8:14 PM Naman Gupta ***@***.***> wrote:
Why not x-axis can have multiple selections?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZ2Y2P35LWOHIGFTVPLPUQ2FDANCNFSM4HL3BXHA>
.
|
|
What about this type of graph? |
|
But I think this will be more complex to do. And also this will consider another axis. |
|
Because we are not introducing any z-axis as of now. |
|
Yes it looks more like a 3 D graph right? |
|
yes, because the kind of data we may have to plot just involve the 2 axes only. |
|
So you are now working on this..so I have started working on selected columns and send it to chart.js for plotting part |
|
yes, right!
…On Thu, May 9, 2019 at 8:21 PM Isha Gupta ***@***.***> wrote:
yes, because the kind of data we may have to plot just involve the 2 axes
only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE6AEYJUOQPT5JFVWBN2BEDPUQ26FANCNFSM4HL3BXHA>
.
|
|
so let me just give you the collected data in a has kind of form, or will you do that? I can explain you the code a little to help you compile this data to a form that can be easily given to chart.js. |
|
Also, I can also help you with the chart.js part because I will also like to explore that library a little. We can work on it together, like you can pass the data and I can work on the design part and graph selection |
|
I think I can look, If I needing some help I will let you know. I will also be making modules and dividing the parsing.js into multiple modules. |
|
Okay, no problem. Let me know once you have passed the data to chart.js, I'll start with remaining work for chart.js |
|
Pass the data? Isn't is it somewhat already done here. Because you are printing the data in the console so I think the passing of data part is done? No? |
|
We already have the selected data ? Right? |
|
We have the data but not in the compiled form for chart.js. You'll have to make it in a hash like format and give it to chart.js. See here: |
|
Okay! I have a doubt in mind. Maybe @jywarren can show some light on it. We can use multiple charts on a single page, right? |
|
Yes I have written all about it in my proposal! We can discuss over it once
you finish the basic plotting!
…On Thu, May 9, 2019, 9:09 PM Naman Gupta ***@***.***> wrote:
Okay! I have a doubt in mind. Maybe @jywarren
<https://github.com/jywarren> can show some light on it. We can use
multiple charts on a single page, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJXHQZYOMLPQ4GV3J3TMGOTPURATRANCNFSM4HL3BXHA>
.
|
|
I looked at it. Its multiple charts from the same CSV file. But I was talking about charts from different csv sheets. Because as of now we are making the system very rigid, or not scalable -- multiple graphs from multiple CSV files, and we are making changes in the |
|
OK, I'm not sure if I'm following exactly, but one way to approach
customization vs. simplicity is to have /very/ strong defaults, which is to
say, thinking of a system which can accommodate flexibility and different
options, but /by default/ uses a simple input and simple output. I think
that's a useful design pattern that could help here, perhaps?
…On Thu, May 9, 2019 at 1:25 PM Naman Gupta ***@***.***> wrote:
I looked at it. Its multiple charts from the same CSV file. But I was
talking about charts from different csv sheets. Because as of now we are
making the system very rigid, or not scalable -- multiple graphs from
multiple CSV files, and we are making changes in the update_file.html
file where we should not do this we should only use this for testing.
Library should be such that after including only one script in any of the
projects we should call a simple function and all this stuff should happen
itself -- this is what happens in the standard libraries as far as I know.
User can do additional styling if he wants to do but that is not necessary,
all the default styling should come only by calling a function. And also we
should divide our code in different module in order to make code modularity.
Let me know your views @jywarren <https://github.com/jywarren> and
@IshaGupta18 <https://github.com/IshaGupta18>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J6RESGHPWYZ4IB4JLDPURM6HANCNFSM4HL3BXHA>
.
|
|
Yes, by default simple input and simple output. Just like other libraries, for example: Chart.js, which provides default output when we pass no additional parameters in functional calling but we have an option to do. It would be better to discuss before, what type of approach and system we want in future. |
|
Yes it will be a good idea in the future, but we'll have to look for efficient ways to implement it, because the implementation might not be very easy. Right now, my approach is to make the system as flexible as it can be, for this point of time. About integration with plots2, we should look at how the Editor has been integrated, because it works very well and is neat. So, yes, we'll have to discuss it at length, on the best way to do this |
|
One minor doubt, related to this. Asked in #18 (comment) |
|
Closing this because already doing in #18 |
fixes #16
Okay so I have written the functions for extracting the sample data and generating the tables for selection of x-axis column and y-axis columns dynamically.
Next step will be to compile the selected columns and send it to chart.js for plotting.
Let me know how this looks @jywarren @namangupta01