Replace tilde at the beginning of the node.Auth.Keys.Path #9

[u5surf]

Fixes #9

Replace tilde at the beginning of the node.Auth.Keys.Path

[Samyak2]

Thanks for the contribution.

When I tested it out, it did not work. See the review comment below for details.

Additionally, the indentation looks off because you have used spaces instead of tabs. Running gofmt on the file should fix this.

[Samyak2]

Thanks.

Upon further testing, I found another issue. While the key gets recognized and transferred (from the SetAuth function), the actual auth when running a command fails because the ~ is not expanded there.

This happens in the Connect function which in turn calls publicKey. So, there is a need to expand ~ just before this line:
https://github.com/psiayn/heiko/blob/fb8b464ec2d4308fde9a4d6cfbcc2762d2851783/internal/connection/establish_connection.go#L25

The following seems to work for now:

	if strings.HasPrefix(path, "~") {
		homePath, err := os.UserHomeDir()
		if err != nil {
			return []ssh.AuthMethod{}
		}
		path = strings.Replace(path, "~", homePath, 1)
	}

---

I understand that the publicKey function isn't great, it should have returned an error when the key wasn't found instead of causing authentication failures. This will have to be refactored later, but for now, just expanding the ~ works.

[Samyak2]

@u5surf any updates on this?

[u5surf]

@Samyak2
I must apologize for my slow work.
I agree with addition the suggestion for now, And I'll add the commit of this.
I'm willing to finish the PR with adding this.

[Samyak2]

@u5surf no worries. Thank you for continuing this PR!