You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces test coverage to validate that single-select form, **eventually_local** fetch strategy on SelectPanel is supported!
I discovered that multi-select for non-local strategies is not yet supported and will additional changes because e JavaScript in select-panel-element.ts overrides whatever hidden fields we add server-side. That should be addressed in a separate PR. I've started #3362 to add relevant previews/tests.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Our visual and ARIA snapshot tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.
khiga8
changed the title
[SelectPanel][tests] form support for eventually_local
[SelectPanel][tests] single-select form support for eventually_localMar 3, 2025
khiga8
changed the title
[SelectPanel][tests] single-select form support for eventually_local
[SelectPanel] single-select form support for eventually_localMar 3, 2025
khiga8
changed the base branch from
main
to
kendallg/test-remote-select-panel-formMarch 3, 2025 22:10
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
khiga8
force-pushed
the
kh-eventually-local-fetch-select-panel
branch
from
Relates to: https://github.com/github/primer/issues/3705#top
What are you trying to accomplish?
This PR introduces test coverage to validate that single-select form,
**eventually_local** fetch strategy on SelectPanel is supported!I discovered that multi-select for non-local strategies is not yet supported and will additional changes because e JavaScript in
select-panel-element.tsoverrides whatever hidden fields we add server-side. That should be addressed in a separate PR. I've started #3362 to add relevant previews/tests.Integration
None of the eventually_local instances on dotcom involve forms, so this should not have any impact.
Risk Assessment
Anything you want to highlight for special attention from reviewers?
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.