Skip to content

Commit 855cd54

Browse files
committed
fix: ensure tests pass
1 parent 7af8d4f commit 855cd54

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

app/components/primer/alpha/select_panel.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ def before_render
534534
def required_inputs_arguments_given?
535535
@inputs.present? &&
536536
@inputs.length > 0 &&
537-
@inputs.each { |input| input[:name].present? && input[:value].present? }
537+
@inputs.all? { |input| input[:name].present? && input[:value].present? }
538538
end
539539

540540
def required_form_arguments_given?

previews/primer/alpha/select_panel_preview/eventually_local_fetch_multiselect_form.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
form_arguments: {
1616
builder: builder,
1717
inputs: [
18-
{ name: :item, value: 3 },
19-
{ name: :item, value: 4 }
18+
{ name: "item", value: 3 },
19+
{ name: "item", value: 4 }
2020
]
2121
}
2222
)) do |panel| %>

test/system/alpha/select_panel_test.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,7 +1317,7 @@ def test_eventually_local_form_single_select_pre_selection
13171317
end
13181318

13191319
def test_eventually_local_form_multi_select_pre_selection
1320-
visit_preview(:eventually_local_fetch_multi_select_form, route_format: :json)
1320+
visit_preview(:eventually_local_fetch_multiselect_form, route_format: :json)
13211321

13221322
assert_selector "input[type='hidden'][name='item'][value='3']", visible: :hidden
13231323
assert_selector "input[type='hidden'][name='item'][value='4']", visible: :hidden
@@ -1338,11 +1338,12 @@ def test_eventually_local_form_selection_updates_with_selection
13381338
click_on_first_item
13391339

13401340
assert_selector "button", text: "Item: Photon torpedo"
1341-
assert_selector "input[type='hidden'][name='item'][value='1']", visible: :hidden
1342-
1341+
assert_selector "input[type='hidden'][name='item'][value='1']", visible: :hidden
13431342
refute_selector "button", text: "Item: Phaser"
13441343
refute_selector "input[type='hidden'][name='item'][value='3']", visible: :hidden
13451344

1345+
click_on "Submit"
1346+
13461347
response = JSON.parse(find("pre").text)
13471348
assert_equal "1", response.dig(*%w(form_params item))
13481349
end

0 commit comments

Comments
 (0)