refactor(ui): Convert class to components to function components, pt 2 #25904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5a85d9.
…ach/presto into function_component_conversion_3
Member
|
@sourcery-ai review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @yhwang, your pull request is too large to review
|
Hi @yhwang! 👋 Only authors and team members can run @sourcery-ai commands on public repos. If you are a team member, install the @sourcery-ai bot to get access ✨ |
cmatzenbach
changed the title
yhwang
reviewed
Oct 28, 2025
Member
yhwang
left a comment
yhwang
left a comment
There was a problem hiding this comment.
finished my first run of review. phrew! nice changes and great effort!
cmatzenbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Third batch of the component conversion started in #25666 (please see PR for background details). This finishes converting all the components in the
components/folder from class components to function components, and with the other two PRs in this series, finishes converting all the class components in the application.Motivation and Context
Resolves item 12 in #21062; function components are the new de-facto standard in react, and benefit from ongoing optimizations in current and future react versions.
Impact
UI
Test Plan
Tested the UI interface extensively, checking all refactored components and their interactions.
Components/interactions tested:
Contributor checklist
Release Notes