Presto UI shows blank for Query Details

[majetideepak]

I see the following error when I inspect

TypeError: Cannot read properties of null (reading 'toFixed')
    at v (979.chunk.js:1:43868)
    at E (979.chunk.js:1:44091)
    at n (979.chunk.js:1:6004)
    at 979.chunk.js:1:7145
    at Array.map (<anonymous>)
    at h (979.chunk.js:1:6847)
    at vo (query.js:1:65924)
    at xi (query.js:1:124893)
    at bs (query.js:1:114141)
    at gs (query.js:1:114069)

See attached screenshot.

Could be due to #25904

[majetideepak]

CC: @tdcmeehan, @yhwang

[pratyakshsharma]

Will be good to verify query viewer (https://prestodb.io/docs/current/clients/presto-console.html#query-viewer) as well once, since the query json was not loading and the screen was blank. I tried with 3 different jsons and none worked.

[yhwang]

hi @pratyakshsharma can you attach your query json files? thanks

[pratyakshsharma]

demo.json

Here is a sample

[yhwang]

hi @pratyakshsharma here is the query viewer of your demo.json

[yhwang]

Thanks @majetideepak for providing more details, and I have the following findings:
I see the following data in the query's JSON fro @majetideepak's environment:

                 "TableScan.0.ioWaitWallNanos": {
                     "name": "TableScan.0.ioWaitWallNanos",
                     "unit": "NANO",
                     "sum": 0,
                     "count": 0,
                     "max": 0,
                     "min": -1000
                 }

The negative value here causes the page not to work. We definitely can handle this in the UI and treat the negative value as 0. But my question is: should we fix this on the server end?

[majetideepak]

@yhwang We will fix this stat on the server side. For the UI, is it possible to throw a meaningful error instead of a blank page?

[yhwang]

@majetideepak, that's a very good suggestion. Here is what I would do:

• Treat the negative value as 0, and the field shows 0 as the value. It would be a rare case after this is fixed on the server side.
• Provide an error log mentioning the negative value.
  Does the solution sound good to you?

[majetideepak]

Treat the negative value as 0, and the field shows 0 as the value. It would be a rare case after this is fixed on the server side.
Provide an error log mentioning the negative value.

Yes. Let's do this so that we can fix the server if we see another instance like this.