-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add documentation for file-based metastore #24511
[docs] Add documentation for file-based metastore #24511
Conversation
@steveburnett I have an issue here with some more details |
@majetideepak I haven't used the file-based Hive metastore much myself, but did you encounter any issues when trying to create partitioned tables? Ideally, it should be possible and I can see that partition-specific metadata calls are implemented even for the FileHiveMetastore. |
@imjalpreet should this be in the hive.properties or config.properties? |
@ethanyzhang These should be in the catalog properties file. I also added a review comment above. |
Thanks for the additional information @majetideepak! With the new information in #19112, I am going to move this topic from where I initially put it in this PR as a small topic in Deploying Presto. I thought about moving it into the Hive Connector doc, but as it is relevant to "Hive and Lakehouse Connectors (Iceberg, Delta, and Hudi)" I think I will move it to its own page in /installation and include Deepak's instructions how to use it, which will be a big help to readers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to include this in the connectors section?
Right now, metastore properties are spread across different parts of the Hive Connector documentation, mainly in Hive Configuration Properties, Metastore Configuration Properties, and Glue Configuration Properties.
Perhaps we could extract the metastore-related documentation into a separate subsection, similar to Hive Security. This would make sense since metastore properties are relevant not just to Hive, but also to other connectors like Iceberg, Delta, and Hudi.
@imjalpreet I remember seeing some issue with partitions and file metastore. It could be due to my setup. I think its good to test this once before documenting. |
I use file bases HMS for development environment, just confirmed again that it supports Hive partitioned tables. Or maybe you encountered some specific problems when using partitioned tables with file bases HMS @majetideepak? |
@hantangwangd If you use it, then it's good. My issue was likely related to my setup. |
@majetideepak I have used partitioned tables too recently with file based HMS. I didn't have any issues. |
03c832f
to
35be659
Compare
Hi everyone, thanks for your feedback! I took @imjalpreet's suggestion and moved this to a separate page in /connector, corrected the directory path that @nmahadevuni noted, added text describing the supported connectors and corrected the instructions for the properties file to the connector property file, and added usage examples from @majetideepak's #19112. I welcome everyone to review again and comment with new corrections and additions. |
@steveburnett, @hantangwangd, @nmahadevuni |
Since we are mentioning one can provide |
35be659
to
a0a7ea5
Compare
Hi everyone! I revised based on the feedback from @nmahadevuni, @majetideepak, and @hantangwangd. PTAL when you can. Specific open questions I haven't addressed in this update:
|
@steveburnett Let's remove |
a0a7ea5
to
a915d6f
Compare
Done and done, thanks! PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @steveburnett.
Thank you @steveburnett. |
1624b09
a915d6f
to
1624b09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveburnett thanks for the PR, LGTM!
@steveburnett is this ready to go? We can ping @yingsu00 to merge |
@ethanyzhang yes, this is ready to merge. |
Description
Add how to configure Presto to use a file-based hms to installation/deployment.rst.
Motivation and Context
@ethanyzhang suggested this would be a good addition to the Presto documentation in an internal discussion that @nmahadevuni contributed the configuration in. I discussed where such information would fit best in the Presto documentation with @tdcmeehan.
Impact
Documentation. Readers wanting to try out Presto quickly can bypass the need for the steps in Configure Hive MetaStore.
Test Plan
Local doc build. Screenshot with existing text above and below included for context.

Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.