Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to steerable pyramid #305

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Updates to steerable pyramid #305

wants to merge 6 commits into from

Conversation

billbrod
Copy link
Member

@billbrod billbrod commented Nov 22, 2024

This PR has two small updates to the steerable pyramid:

  • We had previously raised an error when order=0, which was due to a reconstruction error. Looking into it, this error only happens for the complex pyramid and we now just raise a warning (as for odd-sized images, which have the same problem).
  • We do, however, raise an exception if the user tries to create a complex pyramid with order=0 that is tightframe, since that is impossible.
  • Furthermore, we add a small section to the steerable pyramid notebook showing how to use torch / torchvision to pad or pad and crop, in order to change the behavior at the boundary.

There's a question about where the warning about reconstruction belongs: during pyramid object construction or during the call to the method that actually does the reconstruction (recon_pyr)?

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...e/canonical_computations/steerable_pyramid_freq.py 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
...e/canonical_computations/steerable_pyramid_freq.py 91.27% <87.50%> (-0.18%) ⬇️

@hmd101
Copy link
Contributor

hmd101 commented Nov 23, 2024

Looks good to me!

Copy link
Contributor

@BalzaniEdoardo BalzaniEdoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I agree that the error should be raised at initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants