Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates steerpyr behavior #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

updates steerpyr behavior #39

wants to merge 3 commits into from

Conversation

billbrod
Copy link
Member

@billbrod billbrod commented Nov 25, 2024

Updates behavior of the SteerablePyramidFreq to match the implementation of plenoptic (plenoptic-org/plenoptic#305 and plenoptic-org/plenoptic#306):

  • warn the user about imperfect reconstructing when initializing pyramid with an (odd-sized image) or (order=0 and is_complex=True).
  • raise ValueError if height, order, or twidth are given incorrect values.
  • raise ValueError if height is negative

Note that we don't raise such warnings for SteerabePyramidSpace here because the spatial-domain implementation cannot be complex, and its reconstruction is not perfect anyway (and the errors are approximately the same magnitude when using odd- or even-sized images).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant