-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using nx/js plugin to manage tsc tasks and deps #9530
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6614df1
using nx/js plugin to manage tsc tasks and deps
fungairino 2b463a2
fix config, project.json
fungairino b82342a
Merge branch 'main' into nx-js-plugin
fungairino 4cec186
update package-lock.json
fungairino 891697c
fix knip
fungairino ecb8c8d
remove build:typecheck
fungairino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"targets": { | ||
"build": { | ||
"outputs": ["{workspaceRoot}/dist"], | ||
"cache": true, | ||
"dependsOn": ["^build"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,9 +6,7 @@ | |
"test": "TZ=UTC jest", | ||
"test:ci": "TZ=UTC jest", | ||
"lint": "eslint src --ext js,jsx,ts,tsx --quiet --report-unused-disable-directives", | ||
"lint:fast": "ESLINT_NO_IMPORTS=1 eslint src --ext js,jsx,ts,tsx --quiet", | ||
"build": "tsc --build", | ||
"build:typecheck": "tsc --build" | ||
Comment on lines
-10
to
-11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these two are now provided by the "nx/js" plugin |
||
"lint:fast": "ESLINT_NO_IMPORTS=1 eslint src --ext js,jsx,ts,tsx --quiet" | ||
}, | ||
"main": "./dist/index.js", | ||
"typings": "./dist/index.d.ts", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,33 @@ | ||
{ | ||
"$schema": "./node_modules/nx/schemas/nx-schema.json", | ||
"targetDefaults": { | ||
"build": { | ||
"dependsOn": ["^build"], | ||
"outputs": ["{workspaceRoot}/dist"], | ||
"cache": true | ||
}, | ||
"test": { | ||
"dependsOn": ["^build:typecheck"], | ||
"dependsOn": ["typecheck"], | ||
"cache": true | ||
}, | ||
"test:ci": { | ||
"dependsOn": ["^build:typecheck"], | ||
"dependsOn": ["typecheck"], | ||
"cache": true | ||
}, | ||
"lint": { | ||
"dependsOn": ["^build:typecheck"], | ||
"cache": true | ||
}, | ||
"build:typecheck": { | ||
"dependsOn": ["^build:typecheck"], | ||
"dependsOn": ["typecheck"], | ||
"cache": true | ||
} | ||
}, | ||
"defaultBase": "main", | ||
"defaultProject": "@pixiebrix/extension" | ||
"defaultProject": "@pixiebrix/extension", | ||
"plugins": [ | ||
{ | ||
"plugin": "@nx/js/typescript", | ||
"options": { | ||
"typecheck": { | ||
"targetName": "typecheck" | ||
}, | ||
"build": { | ||
"targetName": "build", | ||
"configName": "tsconfig.lib.json" | ||
} | ||
} | ||
} | ||
] | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here to tell nx to cache the extension project's
build
task (since it overrides the workspace one provided by the nx/js plugin)