-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using nx/js plugin to manage tsc tasks and deps #9530
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9530 +/- ##
==========================================
+ Coverage 74.24% 75.81% +1.56%
==========================================
Files 1332 1429 +97
Lines 40817 43176 +2359
Branches 7634 7948 +314
==========================================
+ Hits 30306 32735 +2429
+ Misses 10511 10441 -70 ☔ View full report in Codecov by Sentry. |
"targets": { | ||
"build": { | ||
"outputs": ["{workspaceRoot}/dist"], | ||
"cache": true, | ||
"dependsOn": ["^build"] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here to tell nx to cache the extension project's build
task (since it overrides the workspace one provided by the nx/js plugin)
"build": "tsc --build", | ||
"build:typecheck": "tsc --build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two are now provided by the "nx/js" plugin
package.json
Outdated
"build:typecheck": "nx typecheck", | ||
"typecheck": "nx typecheck", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"nx/js" calls its task "typecheck".
Temporarily keeping "build:typecheck" so we don't break vercel deployments in this PR (although technically I could rename it to build:typecheck with the targetName
option)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporarily keeping "build:typecheck" so we don't break vercel deployments in this PR (although technically I could rename it to build:typecheck with the targetName option)
I think it's worth just making the change now vs. requiring a FLUP. There are no urgent PRs in the queue / we can always merge without vercel passing
Large lock file is ok I think. swc and nx have a lot of dependencies |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
npm run build
andnpm run typecheck
worksFuture Work