-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Lightning: Make sure we are using default block size of 16KB if user does not specify one. (#60097) #60185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning: Make sure we are using default block size of 16KB if user does not specify one. (#60097) #60185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #60185 +/- ##
================================================
Coverage ? 71.2333%
================================================
Files ? 1468
Lines ? 424046
Branches ? 0
================================================
Hits ? 302062
Misses ? 101456
Partials ? 20528
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #60097
What problem does this PR solve?
Issue Number: close #59947
Problem Summary:
Make we are using a sufficient default block size. Ref #49514
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.