executor: support new sql syntax `show distribution jobs and distribute table t1` #60169

bufferflies · 2025-03-19T07:37:34Z

What problem does this PR solve?

Issue Number: close #60063

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Side effects

mysql> distribute table t rule=leader engine=tikv;
+--------+
| JOB_ID |
+--------+
|      0 |
+--------+
mysql> show distribution jobs;
+--------+----------+-------+----------------+--------+---------+----------+---------------------+---------------------+---------------------+
| Job_ID | Database | Table | Partition_List | Engine | Rule    | Status   | Create_Time         | Start_Time          | Finish_Time         |
+--------+----------+-------+----------------+--------+---------+----------+---------------------+---------------------+---------------------+
|      0 | test     | t     |                | tikv   | leader  | finished | 2025-04-03 11:44:34 | 2025-04-03 11:44:34 | 2025-04-03 12:44:38 |
|      1 | test     | t     |                | tikv   | learner | finished | 2025-04-03 11:44:46 | 2025-04-03 12:44:43 | 2025-04-03 13:44:43 |
+--------+----------+-------+----------------+--------+---------+----------+---------------------+---------------------+---------------------+
mysql> show distribution job 1;
+--------+----------+-------+----------------+--------+---------+----------+---------------------+---------------------+---------------------+
| Job_ID | Database | Table | Partition_List | Engine | Rule    | Status   | Create_Time         | Start_Time          | Finish_Time         |
+--------+----------+-------+----------------+--------+---------+----------+---------------------+---------------------+---------------------+
|      1 | test     | t     |                | tikv   | learner | finished | 2025-04-03 11:44:46 | 2025-04-03 12:44:43 | 2025-04-03 13:44:43 |
+--------+----------+-------+----------------+--------+---------+----------+---------------------+---------------------+---------------------+

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: 童剑 <[email protected]>

ti-chi-bot · 2025-03-19T07:37:36Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2025-03-19T07:37:47Z

Hi @bufferflies. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: 童剑 <[email protected]>

codecov · 2025-04-01T09:26:23Z

Codecov Report

Attention: Patch coverage is 65.67164% with 92 lines in your changes missing coverage. Please review.

Project coverage is 75.5165%. Comparing base (83ee05d) to head (dbcbba6).
Report is 59 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #60169        +/-   ##
================================================
+ Coverage   73.0789%   75.5165%   +2.4375%     
================================================
  Files          1711       1762        +51     
  Lines        473515     495113     +21598     
================================================
+ Hits         346040     373892     +27852     
+ Misses       106161      98560      -7601     
- Partials      21314      22661      +1347

Flag	Coverage Δ
integration	`49.1394% <2.2388%> (?)`
unit	`72.8531% <65.6716%> (+0.5477%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6553% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`61.9120% <ø> (+14.7002%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: 童剑 <[email protected]>

Signed-off-by: bufferflies <[email protected]>

pkg/session/session.go

pkg/executor/show.go

okJiang · 2025-04-10T09:38:19Z

pkg/executor/distribute_table_test.go

+			now.Add(-time.Minute).Format("2006-01-02 15:04:05"),
+			now.Add(-time.Second*30).Format("2006-01-02 15:04:05"))))
+
+	tk.MustQuery("show distribution jobs where `job_id`=1").Check(tk.MustQuery("show distribution job 1").Rows())


Can you add checks for show distribution job 1 and show distribution job 2

job2 is the same as job 0

pkg/planner/core/planbuilder.go

okJiang · 2025-04-10T09:51:33Z

pkg/domain/infosync/region.go

@@ -78,7 +78,31 @@ func GetRegionDistributionByKeyRange(ctx context.Context, startKey []byte, endKe
 		return nil, err
 	}
 	if is.pdHTTPCli == nil {
-		return nil, errs.ErrClientGetLeader.FastGenByArgs("pd client not found")
+		return nil, errs.ErrClientGetLeader.FastGenByArgs("http cli is nil")


Is this error appropriate?

Why use this error(ErrClientGetLeader)? 😂

The HTTP client will init after tidb connects the pd leader, so if the client is nil, it means that the tidb can't get the PD leader

Signed-off-by: bufferflies <[email protected]>

bufferflies · 2025-04-14T01:10:01Z

/test check-dev2

tiprow · 2025-04-14T01:10:24Z

@bufferflies: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/executor/distribute.go

Signed-off-by: bufferflies <[email protected]>

bufferflies · 2025-04-15T09:09:24Z

/test unit-test

tiprow · 2025-04-15T09:09:49Z

@bufferflies: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bufferflies · 2025-04-16T01:14:21Z

/ok-to-test

ti-chi-bot · 2025-04-16T01:41:22Z

@bufferflies: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-unit-test-ddlv1	`74fbf6b`	link	true	`/test pull-unit-test-ddlv1`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bufferflies · 2025-04-16T08:50:25Z

/test unit-test

bufferflies · 2025-04-16T08:50:37Z

/ping @lcwangchao

tiprow · 2025-04-16T08:50:47Z

@bufferflies: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-04-17T02:16:46Z

[LGTM Timeline notifier]

Timeline:

2025-04-14 02:22:06.366959475 +0000 UTC m=+2655020.051195569: ☑️ agreed by okJiang.
2025-04-17 02:16:45.570275204 +0000 UTC m=+2913899.254511297: ☑️ agreed by lcwangchao.

ti-chi-bot · 2025-04-18T03:17:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, hawkingrei, lcwangchao, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,hawkingrei,lcwangchao,okJiang]
~~pkg/domain/OWNERS~~ [GMHDBJD]
~~pkg/planner/OWNERS~~ [hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bufferflies added 6 commits March 12, 2025 15:01

impl parser

f2b8fb9

Signed-off-by: 童剑 <[email protected]>

impl show distribution jobs

4c6f0ee

Signed-off-by: 童剑 <[email protected]>

remove useless code

2d4bdf8

Signed-off-by: 童剑 <[email protected]>

add two unit test case

d675ea3

Signed-off-by: 童剑 <[email protected]>

show distribution jobs

2beb47e

Signed-off-by: 童剑 <[email protected]>

add test for show distribution job

10afdb2

Signed-off-by: 童剑 <[email protected]>

add test for distribut table

ab8c2ad

Signed-off-by: 童剑 <[email protected]>

ti-chi-bot bot removed the do-not-merge/needs-linked-issue label Mar 27, 2025

fetch origin

ffe0875

Signed-off-by: 童剑 <[email protected]>

ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2025

remove unused changes

a4f7cdd

Signed-off-by: 童剑 <[email protected]>

ti-chi-bot bot removed the do-not-merge/needs-tests-checked label Mar 27, 2025

bufferflies marked this pull request as ready for review March 27, 2025 08:45

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025

bufferflies added 2 commits April 1, 2025 11:39

resolve conflict

51ee647

Signed-off-by: 童剑 <[email protected]>

finish jobs

e706ec6

Signed-off-by: 童剑 <[email protected]>

bufferflies added 3 commits April 1, 2025 18:26

lint

e351cb7

Signed-off-by: 童剑 <[email protected]>

lint

017cc71

Signed-off-by: bufferflies <[email protected]>

fetch origin master

2fa9f48

Signed-off-by: bufferflies <[email protected]>

ti-chi-bot bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 9, 2025

okJiang reviewed Apr 10, 2025

View reviewed changes

bufferflies force-pushed the executor/distribute_table branch 3 times, most recently from 5fc6168 to cc80a4a Compare April 10, 2025 11:48

address comment

cd3e584

Signed-off-by: bufferflies <[email protected]>

bufferflies force-pushed the executor/distribute_table branch from cc80a4a to cd3e584 Compare April 11, 2025 08:42

okJiang approved these changes Apr 14, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 14, 2025

lcwangchao reviewed Apr 15, 2025

View reviewed changes

pkg/executor/distribute.go Outdated Show resolved Hide resolved

add some comment for the alias

dbcbba6

Signed-off-by: bufferflies <[email protected]>

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 16, 2025

bufferflies requested a review from lcwangchao April 16, 2025 01:15

lcwangchao approved these changes Apr 17, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2025

hawkingrei approved these changes Apr 18, 2025

View reviewed changes

GMHDBJD approved these changes Apr 18, 2025

View reviewed changes

ti-chi-bot bot added the approved label Apr 18, 2025

ti-chi-bot bot merged commit ee95b9b into pingcap:master Apr 18, 2025
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor: support new sql syntax `show distribution jobs and distribute table t1` #60169

executor: support new sql syntax `show distribution jobs and distribute table t1` #60169

bufferflies commented Mar 19, 2025 •

edited

Loading

ti-chi-bot bot commented Mar 19, 2025

tiprow bot commented Mar 19, 2025

codecov bot commented Apr 1, 2025 •

edited

Loading

okJiang Apr 10, 2025

bufferflies Apr 10, 2025

okJiang Apr 10, 2025

bufferflies Apr 10, 2025

okJiang Apr 11, 2025

bufferflies Apr 14, 2025

bufferflies commented Apr 14, 2025

tiprow bot commented Apr 14, 2025

bufferflies commented Apr 15, 2025

tiprow bot commented Apr 15, 2025

bufferflies commented Apr 16, 2025

ti-chi-bot bot commented Apr 16, 2025 •

edited

Loading

bufferflies commented Apr 16, 2025

bufferflies commented Apr 16, 2025

tiprow bot commented Apr 16, 2025

ti-chi-bot bot commented Apr 17, 2025

ti-chi-bot bot commented Apr 18, 2025

executor: support new sql syntax show distribution jobs and distribute table t1 #60169

executor: support new sql syntax show distribution jobs and distribute table t1 #60169

Conversation

bufferflies commented Mar 19, 2025 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Mar 19, 2025

tiprow bot commented Mar 19, 2025

codecov bot commented Apr 1, 2025 • edited Loading

Codecov Report

okJiang Apr 10, 2025

Choose a reason for hiding this comment

bufferflies Apr 10, 2025

Choose a reason for hiding this comment

okJiang Apr 10, 2025

Choose a reason for hiding this comment

bufferflies Apr 10, 2025

Choose a reason for hiding this comment

okJiang Apr 11, 2025

Choose a reason for hiding this comment

bufferflies Apr 14, 2025

Choose a reason for hiding this comment

bufferflies commented Apr 14, 2025

tiprow bot commented Apr 14, 2025

bufferflies commented Apr 15, 2025

tiprow bot commented Apr 15, 2025

bufferflies commented Apr 16, 2025

ti-chi-bot bot commented Apr 16, 2025 • edited Loading

bufferflies commented Apr 16, 2025

bufferflies commented Apr 16, 2025

tiprow bot commented Apr 16, 2025

ti-chi-bot bot commented Apr 17, 2025

[LGTM Timeline notifier]

ti-chi-bot bot commented Apr 18, 2025

executor: support new sql syntax `show distribution jobs and distribute table t1` #60169

executor: support new sql syntax `show distribution jobs and distribute table t1` #60169

bufferflies commented Mar 19, 2025 •

edited

Loading

codecov bot commented Apr 1, 2025 •

edited

Loading

ti-chi-bot bot commented Apr 16, 2025 •

edited

Loading