meta: fix incorrect foreign key field init in table info clone #60103

River2000i · 2025-03-17T05:49:25Z

What problem does this PR solve?

Issue Number: close #60044

Problem Summary: br restroe table will clone table info before create table, it will meet the incorrect null foreign key field init. Fix incorrect load foreign key init in tableInfo.Clone() because of make([]*FKInfo, len(t.ForeignKeys))

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

River2000i · 2025-03-17T05:49:33Z

/ok-to-test

ti-chi-bot · 2025-03-17T05:49:35Z

Hi @River2000i. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-17T05:49:48Z

Hi @River2000i. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-03-17T05:49:50Z

@River2000i: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-17T05:49:56Z

@River2000i: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Leavrth

rest LGTM

pkg/meta/model/table.go

Leavrth · 2025-03-17T07:07:12Z

pkg/meta/model/table.go

@@ -242,7 +242,13 @@ func (t *TableInfo) Clone() *TableInfo {
 	nt := *t
 	nt.Columns = make([]*ColumnInfo, len(t.Columns))
 	nt.Indices = make([]*IndexInfo, len(t.Indices))
-	nt.ForeignKeys = make([]*FKInfo, len(t.ForeignKeys))
+
+	if t.ForeignKeys != nil {


maybe need to set nt.ForeignKeys = nil if t.ForeignKeys is []*FKInfo{}.

default ForeignKeys is nil, seems it's not necessary check nil or len(0)🤔
https://github.com/pingcap/tidb/blob/master/pkg/ddl/create_table.go#L1219-L1224

@GMHDBJD PTAL~

I'm worried about if the tableInfo is from the old version. For example, it is from backup or the cluster origin data after tidb upgrade.

ok, we can unify nil and len(0) into nil in clone.

hawkingrei · 2025-03-17T07:30:13Z

/ok-to-test

codecov · 2025-03-17T07:51:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8196%. Comparing base (77f118f) to head (49d43e5).
Report is 9 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #60103        +/-   ##
================================================
+ Coverage   73.1493%   73.8196%   +0.6702%     
================================================
  Files          1706       1707         +1     
  Lines        471415     473576      +2161     
================================================
+ Hits         344837     349592      +4755     
+ Misses       105415     102883      -2532     
+ Partials      21163      21101        -62

Flag	Coverage Δ
integration	`43.0417% <100.0000%> (?)`
unit	`72.5705% <100.0000%> (+0.2353%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`47.3161% <ø> (+0.0980%)`	⬆️

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GMHDBJD

LGTM

ti-chi-bot · 2025-03-17T08:15:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/meta/OWNERS~~ [GMHDBJD]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-03-17T08:15:27Z

[LGTM Timeline notifier]

Timeline:

2025-03-17 08:10:28.149290085 +0000 UTC m=+256721.833526165: ☑️ agreed by Leavrth.
2025-03-17 08:15:26.895293501 +0000 UTC m=+257020.579529597: ☑️ agreed by GMHDBJD.

River2000i · 2025-03-17T10:24:23Z

/retest

River2000i · 2025-03-17T13:55:03Z

/retest

River2000i · 2025-03-17T16:14:05Z

/retest

ti-chi-bot · 2025-03-17T16:37:54Z

In response to a cherrypick label: new pull request created to branch release-9.0-beta.1: #60129.

…60129) close #60044

tableinfo not need to clone foreighn key

4313d0d

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 17, 2025

ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 17, 2025

ti-chi-bot bot removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Mar 17, 2025

River2000i changed the title ~~[WIP]meta: tableinfo not need to clone foreighn key~~ [WIP]meta: tableinfo not need to clone foreign key Mar 17, 2025

add tableInfo clone with IsTableInfoMustLoad test

2ea9940

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025

River2000i changed the title ~~[WIP]meta: tableinfo not need to clone foreign key~~ meta: clone table info not need to new foreign keys Mar 17, 2025

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025

fix clone

b95d1e7

River2000i changed the title ~~meta: clone table info not need to new foreign keys~~ meta: clone table info with new foreign keys when not nil Mar 17, 2025

fix

d248a39

Leavrth reviewed Mar 17, 2025

View reviewed changes

pkg/meta/model/table.go Outdated Show resolved Hide resolved

Leavrth reviewed Mar 17, 2025

View reviewed changes

ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 17, 2025

fix

d8a9449

address comment

49d43e5

River2000i requested a review from Leavrth March 17, 2025 08:09

Leavrth approved these changes Mar 17, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 17, 2025

GMHDBJD approved these changes Mar 17, 2025

View reviewed changes

ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025

River2000i changed the title ~~meta: clone table info with new foreign keys when not nil~~ meta: clone table info with new foreign keys default to nil Mar 17, 2025

ti-chi-bot bot added the needs-cherry-pick-release-9.0-beta.1 label Mar 17, 2025

ti-chi-bot bot merged commit c508e4b into pingcap:master Mar 17, 2025
25 checks passed

ti-chi-bot mentioned this pull request Mar 17, 2025

meta: clone table info with new foreign keys default to nil (#60103) #60129

Merged

13 tasks

River2000i changed the title ~~meta: clone table info with new foreign keys default to nil~~ meta: fix incorrect foreign key field init in table info clone Mar 18, 2025

ti-chi-bot bot pushed a commit that referenced this pull request Mar 24, 2025

meta: clone table info with new foreign keys default to nil (#60103) (#…

7aff918

…60129) close #60044

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: fix incorrect foreign key field init in table info clone #60103

meta: fix incorrect foreign key field init in table info clone #60103

River2000i commented Mar 17, 2025 •

edited

Loading

River2000i commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

Leavrth left a comment

Leavrth Mar 17, 2025

River2000i Mar 17, 2025

Leavrth Mar 17, 2025

River2000i Mar 17, 2025

hawkingrei commented Mar 17, 2025

codecov bot commented Mar 17, 2025 •

edited

Loading

GMHDBJD left a comment

ti-chi-bot bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

River2000i commented Mar 17, 2025

River2000i commented Mar 17, 2025

River2000i commented Mar 17, 2025

ti-chi-bot commented Mar 17, 2025

meta: fix incorrect foreign key field init in table info clone #60103

meta: fix incorrect foreign key field init in table info clone #60103

Conversation

River2000i commented Mar 17, 2025 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

River2000i commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

tiprow bot commented Mar 17, 2025

Leavrth left a comment

Choose a reason for hiding this comment

Leavrth Mar 17, 2025

Choose a reason for hiding this comment

River2000i Mar 17, 2025

Choose a reason for hiding this comment

Leavrth Mar 17, 2025

Choose a reason for hiding this comment

River2000i Mar 17, 2025

Choose a reason for hiding this comment

hawkingrei commented Mar 17, 2025

codecov bot commented Mar 17, 2025 • edited Loading

Codecov Report

GMHDBJD left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Mar 17, 2025

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

River2000i commented Mar 17, 2025

River2000i commented Mar 17, 2025

River2000i commented Mar 17, 2025

ti-chi-bot commented Mar 17, 2025

River2000i commented Mar 17, 2025 •

edited

Loading

codecov bot commented Mar 17, 2025 •

edited

Loading