Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: (8.1) fix TSO retrieval failure during read TS validation #59521

Open
wants to merge 2 commits into
base: release-8.1
Choose a base branch
from

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Feb 13, 2025

What problem does this PR solve?

Issue Number: ref #59402

Problem Summary:

What changed and how does it work?

Do not set txn scope in snapshot to fix the problem.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix TSO retrieval failure during read TS validation when `zone` label is set.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Feb 13, 2025
@ekexium ekexium force-pushed the release-8.1-fix-59402 branch from 079ad0b to 86bbd5c Compare February 13, 2025 13:53
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@5ac7f18). Learn more about missing BASE report.

Current head 836beeb differs from pull request most recent head 2ac5b3d

Please upload reports for the commit 2ac5b3d to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #59521   +/-   ##
================================================
  Coverage               ?   71.2102%           
================================================
  Files                  ?       1468           
  Lines                  ?     424019           
  Branches               ?          0           
================================================
  Hits                   ?     301945           
  Misses                 ?     101526           
  Partials               ?      20548           
Flag Coverage Δ
unit 71.2102% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.4273% <0.0000%> (?)

Signed-off-by: ekexium <[email protected]>
@ekexium ekexium force-pushed the release-8.1-fix-59402 branch from 86bbd5c to 836beeb Compare February 13, 2025 14:56
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 17, 2025
Signed-off-by: ekexium <[email protected]>
@ekexium
Copy link
Member Author

ekexium commented Feb 19, 2025

/retest

Copy link

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
Copy link

ti-chi-bot bot commented Feb 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-17 08:07:47.27851265 +0000 UTC m=+862309.674734713: ☑️ agreed by MyonKeminta.
  • 2025-02-19 07:50:15.260993429 +0000 UTC m=+1034057.657215491: ☑️ agreed by cfzjywxk.

@ekexium
Copy link
Member Author

ekexium commented Feb 19, 2025

/retest

Copy link

ti-chi-bot bot commented Feb 19, 2025

@ekexium: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 2ac5b3d link true /test unit-test
idc-jenkins-ci-tidb/build 2ac5b3d link true /test build
idc-jenkins-ci-tidb/check_dev 2ac5b3d link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 2ac5b3d link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants