-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: mem dump when about to OOM #59234
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Wenqi Mou <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59234 +/- ##
================================================
+ Coverage 73.0563% 74.6834% +1.6270%
================================================
Files 1689 1706 +17
Lines 467012 467248 +236
================================================
+ Hits 341182 348957 +7775
+ Misses 104853 96549 -8304
- Partials 20977 21742 +765
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
What problem does this PR solve?
Issue Number: close #56971
Problem Summary:
What changed and how does it work?
Added a memory monitor that dumps the heap dump before it's about to OOM (reach 90% of mem), logs memory usage warning when reaching 80%.
Keeps only max 3 heap dumps so not spamming the disk
Generate only at 5 mins interval if needed
Output dir is configured though env and it should be persistent, default is /tmp/heapdump
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.