Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add tests to cover sequence id, auto increment id and auto random id, revert meta kv capture logic #59109

Merged
merged 5 commits into from
Jan 26, 2025
Merged

br: add tests to cover sequence id, auto increment id and auto random id, revert meta kv capture logic #59109

merged 5 commits into from
Jan 26, 2025

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Jan 21, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #59108

Problem Summary:

What changed and how does it work?

Add tests to cover sequence id, auto increment id and auto random id cases are correctly handled in PiTR life cycle

Revert the change in rewrite meta kv to return error instead of nil when items not found in db replace map to make sure it's absolutely safe. Will find another way to handle filtered items in next PR

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 21, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 21, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.27273% with 58 lines in your changes missing coverage. Please review.

Project coverage is 74.9893%. Comparing base (7cee190) to head (c3be5c0).
Report is 24 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59109        +/-   ##
================================================
+ Coverage   73.1112%   74.9893%   +1.8780%     
================================================
  Files          1684       1705        +21     
  Lines        466366     480739     +14373     
================================================
+ Hits         340966     360503     +19537     
+ Misses       104467      97902      -6565     
- Partials      20933      22334      +1401
Flag Coverage Δ
integration 46.5299% <47.2727%> (?)
unit 72.5055% <47.2727%> (+0.1920%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.0594% <47.2727%> (+16.7362%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2025
@Tristan1900
add unit test, fix format
f11bb1d 
Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900 Tristan1900 changed the title br: add tests to cover sequence id, auto increment id and auto random id br: add tests to cover sequence id, auto increment id and auto random id, revert meta kv capture logic Jan 23, 2025
@Tristan1900
fix bazel
c3be5c0 
Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 23, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 23, 2025

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2025
BornChanger
BornChanger reviewed Jan 24, 2025
View reviewed changes
br/tests/br_pitr/prepare_data/key_types.sql
);
INSERT INTO key_types_test.sequence_test (name) VALUES ('seq1'), ('seq2'), ('seq3');

-- 4. auto Random Table ID Key Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add one more pattern where autorandom is part of the primary as in issue #52255.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, interesting case, let me add that

BornChanger
BornChanger reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others lgtm

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 26, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-24 05:30:35.750467645 +0000 UTC m=+417963.081387034: ☑️ agreed by YuJuncen.
  • 2025-01-26 06:10:21.295590605 +0000 UTC m=+593148.626510008: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit debfc32 into pingcap:master Jan 26, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger left review comments

@Leavrth Leavrth Leavrth approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: add test to cover sequence, auto increment id auto random in log backup/restore
4 participants
@Tristan1900 @YuJuncen @Leavrth @BornChanger