Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Add a GetDBMeta function to meta. #53684

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented May 30, 2024

What problem does this PR solve?

Issue Number: close #53685

Problem Summary:

What changed and how does it work?

Add a function named GetDBMeta to meta.go. This function will allow the caller to get all raw tableInfos of database.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
    Covered by the existing unit test cases.

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2024
Copy link

tiprow bot commented May 30, 2024

Hi @asddongmen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/meta/meta.go Outdated Show resolved Hide resolved
Signed-off-by: dongmen <[email protected]>
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.8330%. Comparing base (04c66ee) to head (da2bcc7).
Report is 24 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #53684         +/-   ##
=================================================
- Coverage   74.4884%   55.8330%   -18.6554%     
=================================================
  Files          1506       1626        +120     
  Lines        357618     606999     +249381     
=================================================
+ Hits         266384     338906      +72522     
- Misses        71857     244923     +173066     
- Partials      19377      23170       +3793     
Flag Coverage Δ
integration 36.3214% <62.5000%> (?)
unit 71.4139% <62.5000%> (-1.9534%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-3.3316%) ⬇️
parser ∅ <ø> (∅)
br 50.3214% <ø> (+6.7579%) ⬆️

pkg/meta/meta.go Outdated Show resolved Hide resolved
pkg/meta/meta.go Outdated Show resolved Hide resolved
@asddongmen
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2024
@D3Hunter
Copy link
Contributor

what kind of filter will CDC use?

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2024
@asddongmen asddongmen changed the title meta: Add a ListTableByFilter function to meta. meta: Add a GetDBMeta function to meta. May 31, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 31, 2024
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/meta/meta.go Outdated Show resolved Hide resolved
pkg/meta/meta_test.go Outdated Show resolved Hide resolved
asddongmen and others added 2 commits May 31, 2024 17:03
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 31, 2024
Copy link

ti-chi-bot bot commented May 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 08:23:23.285807515 +0000 UTC m=+3023957.042943088: ☑️ agreed by CharlesCheung96.
  • 2024-05-31 09:07:14.244842403 +0000 UTC m=+3026588.001977976: ☑️ agreed by D3Hunter.

Copy link

ti-chi-bot bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, D3Hunter, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 31, 2024
Copy link

tiprow bot commented May 31, 2024

@asddongmen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow a570b9d link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@asddongmen asddongmen removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7629a0d into master Jun 4, 2024
21 checks passed
@ti-chi-bot ti-chi-bot bot deleted the add_a_function_to_meta branch June 4, 2024 03:22
@asddongmen asddongmen added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 4, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53780.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #53781.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function named GetDBMeta to meta.go.
7 participants