log backup: fix the issue that paused service safepoint not removed

[3pointer]

What problem does this PR solve?

Issue Number: close #52082

Problem Summary:
stop task didn't remove service safepoint correctly.

What changed and how does it work?

1. set ttl == 0 to make pd service remove this safepoint.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that stop log backup didn't clean paused task gc safepoint correctly.

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @3pointer. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[YuJuncen]

If I recall right we remove the safepoint by setting the ts to zero before. Will set TTL to zero work?

[3pointer]

yes, and if set ts to 0. it won't pass the check before connect to pd to remove this safepoint.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-03-27 09:35:21.887202733 +0000 UTC m=+2060548.909449118: ☑️ agreed by YuJuncen.
• 2024-03-28 08:01:51.550013676 +0000 UTC m=+2141338.572260064: ☑️ agreed by Leavrth.

[codecov]

Codecov Report

Merging #52106 (2c94cb0) into master (422ae46) will increase coverage by 0.4279%.
Report is 3 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52106        +/-   ##
================================================
+ Coverage   72.4123%   72.8402%   +0.4279%     
================================================
  Files          1490       1499         +9     
  Lines        366232     441359     +75127     
================================================
+ Hits         265197     321487     +56290     
- Misses        81461      99689     +18228     
- Partials      19574      20183       +609     

Flag	Coverage Δ
integration	48.8941% <0.0000%> (?)
unit	70.5510% <0.0000%> (-1.7512%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	51.4204% <0.0000%> (+5.1215%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [BornChanger,Leavrth,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BornChanger]

/retest

[tiprow]

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[3pointer]

/retest

[tiprow]

@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[3pointer]

/ok-to-test

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #52248.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #52249.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #52250.