Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: add gotag enableassert for make server_check #51057

Merged
merged 26 commits into from
Oct 18, 2024
Merged

Makefile: add gotag enableassert for make server_check #51057

merged 26 commits into from
Oct 18, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Feb 7, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

There's some error check enabled by gotag intest.

And we're moving tests from Golang's unit test to the integration tests. We need to use the binary which is compiled with the gotag.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros winoros added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 7, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.4948%. Comparing base (c18eaa7) to head (9f5929a).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #51057         +/-   ##
=================================================
- Coverage   73.3439%   57.4948%   -15.8491%     
=================================================
  Files          1629       1823        +194     
  Lines        450157     680219     +230062     
=================================================
+ Hits         330163     391091      +60928     
- Misses        99731     263801     +164070     
- Partials      20263      25327       +5064
Flag Coverage Δ
integration 36.9181% <90.4761%> (?)
unit 72.5691% <83.3333%> (+0.1007%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3637% <ø> (+5.7974%) ⬆️

@winoros
Copy link
Member Author

winoros commented Feb 8, 2024

It's so surprising that some tests failed when we added the gotags.
I'll check it later.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2024
@winoros
Copy link
Member Author

winoros commented Feb 18, 2024

/retest

okJiang
okJiang approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need a issue

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-11 15:13:12.776350205 +0000 UTC m=+715318.343120096: ☑️ agreed by AilinKid.
  • 2024-02-26 10:25:09.85847818 +0000 UTC m=+871198.606101288: ☑️ agreed by okJiang.

@hawkingrei
Copy link
Member

/retest

4 similar comments
@winoros
Copy link
Member Author

winoros commented Mar 7, 2024

/retest

@hawkingrei
Copy link
Member

/retest

@winoros
Copy link
Member Author

winoros commented Mar 18, 2024

/retest

@winoros
Copy link
Member Author

winoros commented Mar 29, 2024

/retest

@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024
@winoros
Copy link
Member Author

winoros commented Jul 19, 2024

/hold for a while

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
winoros
winoros commented Jul 19, 2024
View reviewed changes
pkg/executor/infoschema_reader.go
@@ -308,7 +308,8 @@ func (e *memtableRetriever) setDataForVariablesInfo(ctx sessionctx.Context) erro

func (e *memtableRetriever) setDataForUserAttributes(ctx context.Context, sctx sessionctx.Context) error {
exec := sctx.GetRestrictedSQLExecutor()
chunkRows, _, err := exec.ExecRestrictedSQL(ctx, nil, `SELECT user, host, JSON_UNQUOTE(JSON_EXTRACT(user_attributes, '$.metadata')) FROM mysql.user`)
wrappedCtx := kv.WithInternalSourceType(ctx, kv.InternalTxnOthers)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a missed one. Found by the intest tag.

@winoros
Copy link
Member Author

winoros commented Jul 19, 2024

QQ_1721402706884
Now that the check_dev can pass.
We know that the failure is caused by
QQ_1721402744264

I'm trying to solve it without enlarging the cache size too much.

@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
@winoros winoros force-pushed the add-test-tag-for-check-bin branch from f3efa8a to 918faba Compare September 23, 2024 15:33
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 23, 2024
@winoros
Copy link
Member Author

winoros commented Sep 27, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2024
@XuHuaiyu
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Sep 29, 2024
@winoros
Copy link
Member Author

winoros commented Sep 29, 2024

/retest

@winoros
Copy link
Member Author

winoros commented Oct 16, 2024

/retest

@ti-chi-bot ti-chi-bot bot removed the approved label Oct 17, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Oct 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, lance6716, Leavrth, okJiang, tangenta, wjhuang2016, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@winoros winoros force-pushed the add-test-tag-for-check-bin branch from 9ca32aa to 9f5929a Compare October 18, 2024 08:22
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2024 •
edited
Loading

@winoros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test f3efa8a link true /test pull-br-integration-test
pull-lightning-integration-test f3efa8a link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@winoros
Copy link
Member Author

winoros commented Oct 18, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 55b3e37 into pingcap:master Oct 18, 2024
23 checks passed
@winoros winoros deleted the add-test-tag-for-check-bin branch October 18, 2024 13:46
@winoros winoros changed the title Makefile: add gotag for make server_check Makefile: add gotag enableassert for make server_check Oct 18, 2024
@winoros winoros mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@Leavrth Leavrth Leavrth approved these changes

@tangenta tangenta tangenta approved these changes

@okJiang okJiang okJiang approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@winoros @hawkingrei @XuHuaiyu @lance6716 @D3Hunter @AilinKid @wjhuang2016 @okJiang @tangenta @Leavrth