update

Signed-off-by: Weizhen Wang <[email protected]>

pkg/expression/util.go

@@ -2162,3 +2162,16 @@ func binaryDurationWithMS(pos int, paramValues []byte,
 	pos += 4
 	return pos, fmt.Sprintf("%s.%06d", dur, microSecond)
 }
+
+// IsConstFalse is used to check whether the expression is a constant false expression.
+func IsConstFalse(expr Expression) bool {
+	if e, ok := expr.(*ScalarFunction); ok {
+		switch e.FuncName.L {
+		case ast.LT, ast.LE, ast.GT, ast.GE, ast.EQ, ast.NE:
+			if constExpr, ok := e.GetArgs()[1].(*Constant); ok && constExpr.Value.IsNull() && constExpr.DeferredExpr == nil {
+				return true
+			}
+		}
+	}
+	return false
+}

pkg/planner/core/operator/logicalop/expression_util.go

@@ -16,27 +16,13 @@ package logicalop
 
 import (
 	"github.com/pingcap/tidb/pkg/expression"
-	"github.com/pingcap/tidb/pkg/parser/ast"
 	"github.com/pingcap/tidb/pkg/planner/core/base"
 )
 
-// isConstFalse is used to check whether the expression is a constant false expression.
-func isConstFalse(expr expression.Expression) bool {
-	if e, ok := expr.(*expression.ScalarFunction); ok {
-		switch e.FuncName.L {
-		case ast.LT, ast.LE, ast.GT, ast.GE, ast.EQ, ast.NE:
-			if constExpr, ok := e.GetArgs()[1].(*expression.Constant); ok && constExpr.Value.IsNull() && constExpr.DeferredExpr == nil {
-				return true
-			}
-		}
-	}
-	return false
-}
-
 // Conds2TableDual builds a LogicalTableDual if cond is constant false or null.
 func Conds2TableDual(p base.LogicalPlan, conds []expression.Expression) base.LogicalPlan {
 	for _, cond := range conds {
-		if isConstFalse(cond) {
+		if expression.IsConstFalse(cond) {
 			if expression.MaybeOverOptimized4PlanCache(p.SCtx().GetExprCtx(), conds) {
 				return nil
 			}