Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obsolete detectors #163

Merged
merged 1 commit into from
Jun 4, 2024
Merged

obsolete detectors #163

merged 1 commit into from
Jun 4, 2024

Conversation

Yhtiyar
Copy link
Member

@Yhtiyar Yhtiyar commented May 30, 2024

No description provided.

@Yhtiyar Yhtiyar requested a review from ndkirillov May 30, 2024 07:14
ndkirillov
ndkirillov requested changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@ndkirillov ndkirillov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's:

  • add a flag to the cli for the convenience
  • mark obsolete detectors in docs (create a new directory or directly in .md)

slitherin/consts.py Show resolved Hide resolved
slitherin/detectors/obsolete/README.md Show resolved Hide resolved
ndkirillov
ndkirillov approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@ndkirillov ndkirillov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yhtiyar Yhtiyar merged commit 9833de9 into develop Jun 4, 2024
2 checks passed
@Yhtiyar Yhtiyar deleted the obsolete branch June 4, 2024 10:55
@ndkirillov ndkirillov added the enhancement New feature or request label Jun 6, 2024
@ndkirillov ndkirillov added this to the 0.7.1 version milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkirillov ndkirillov ndkirillov approved these changes

Assignees

@Yhtiyar Yhtiyar

@ndkirillov ndkirillov

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.1 version
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yhtiyar @ndkirillov