Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dubious typecast: add Safecast to whitelist #162

Merged
merged 2 commits into from
May 28, 2024
Merged

Dubious typecast: add Safecast to whitelist #162

merged 2 commits into from
May 28, 2024

Conversation

Yhtiyar
Copy link
Member

@Yhtiyar Yhtiyar commented May 27, 2024

Added OZ math/safecast libraries to whiteliist

@Yhtiyar Yhtiyar requested a review from ndkirillov May 27, 2024 12:16
ndkirillov
ndkirillov requested changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@ndkirillov ndkirillov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the documentation file so it would become clearer what this detector is about?

ndkirillov
ndkirillov approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@ndkirillov ndkirillov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yhtiyar Yhtiyar merged commit 2777939 into develop May 28, 2024
2 checks passed
@Yhtiyar Yhtiyar deleted the safecast-whitelist branch May 28, 2024 10:56
@ndkirillov ndkirillov added the enhancement New feature or request label Jun 6, 2024
@ndkirillov ndkirillov added this to the 0.7.1 version milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkirillov ndkirillov ndkirillov approved these changes

Assignees

@Yhtiyar Yhtiyar

@ndkirillov ndkirillov

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.1 version
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yhtiyar @ndkirillov