Skip to content

Fix some missing includes.#423

Closed
hzeller wants to merge 1 commit into
parallaxsw:masterfrom
hzeller:feature-20260414-fix-missing-inc
Closed

Fix some missing includes.#423
hzeller wants to merge 1 commit into
parallaxsw:masterfrom
hzeller:feature-20260414-fix-missing-inc

Conversation

@hzeller
Copy link
Copy Markdown
Contributor

@hzeller hzeller commented Apr 14, 2026

And sort the headers in the affected files according to style guide.

Breakdown

util/RiseFallMinMax.cc:                  #include "MinMax.hh" for sta::MinMaxAll
sdc/Variables.cc:                        #include "PocvMode.hh" for sta::PocvMode
sdc/PortExtCap.cc:                       #include "NetworkClass.hh" for sta::Port
util/ReportTcl.cc:                       #include "Report.hh" for sta::Report
util/RiseFallMinMaxDelay.cc:             #include "StaState.hh" for sta::StaState
util/RiseFallMinMax.cc:                  #include "Transition.hh" for sta::RiseFallBoth
util/RiseFallValues.cc:                  #include "Transition.hh" for sta::RiseFallBoth
sdc/PortExtCap.cc:                       #include "MinMax.hh" for sta::MinMax
util/RiseFallMinMaxDelay.cc:             #include "MinMax.hh" for sta::MinMax
dcalc/DelayNormal.cc:                    #include "Delay.hh" for sta::Delay
dcalc/DelayScalar.cc:                    #include "Delay.hh" for sta::Delay
dcalc/DelaySkewNormal.cc:                #include "Delay.hh" for sta::Delay
util/RiseFallMinMaxDelay.cc:             #include "Delay.hh" for sta::Delay
dcalc/Delay.cc:                          #include "MinMax.hh" for sta::EarlyLate
dcalc/DelayNormal.cc:                    #include "MinMax.hh" for sta::EarlyLate
dcalc/DelayScalar.cc:                    #include "MinMax.hh" for sta::EarlyLate
dcalc/DelaySkewNormal.cc:                #include "MinMax.hh" for sta::EarlyLate
sdc/PortExtCap.cc:                       #include "Transition.hh" for sta::RiseFall
util/RiseFallMinMaxDelay.cc:             #include "Transition.hh" for sta::RiseFall
util/MinMax.cc:                          #include <array> for std::array
util/Transition.cc:                      #include <array> for std::array
power/VcdParse.cc:                       #include <stdexcept> for std::invalid_argument
dcalc/FindRoot.cc:                       #include <utility> for std::pair
util/StringUtil.cc:                      #include <utility> for std::pair
dcalc/Delay.cc:                          #include <string> for std::string
dcalc/DelayNormal.cc:                    #include <string> for std::string
dcalc/DelayScalar.cc:                    #include <string> for std::string
dcalc/DelaySkewNormal.cc:                #include <string> for std::string
liberty/Units.cc:                        #include <string> for std::string
network/VerilogNamespace.cc:             #include <string> for std::string
power/VcdParse.cc:                       #include <string> for std::string
search/PocvMode.cc:                      #include <string> for std::string
util/Error.cc:                           #include <string> for std::string
util/PatternMatch.cc:                    #include <string> for std::string
util/Report.cc:                          #include <string> for std::string
util/StringUtil.cc:                      #include <string> for std::string
util/Transition.cc:                      #include <string> for std::string
dcalc/ArnoldiDelayCalc.cc:               #include "Error.hh" for criticalError
search/GatedClk.cc:                      #include "Error.hh" for criticalError
search/Levelize.cc:                      #include "Error.hh" for criticalError
util/Report.cc:                          #include <cstdio> for printf
util/MachineWin32.cc:                    #include <cstdarg> for va_list

@hzeller hzeller force-pushed the feature-20260414-fix-missing-inc branch from fc44ad7 to 9d9f5b1 Compare April 14, 2026 09:57
And sort the headers in the affected files according to style guide.

Breakdown
```
util/RiseFallMinMax.cc:                  #include "MinMax.hh" for sta::MinMaxAll
sdc/Variables.cc:                        #include "PocvMode.hh" for sta::PocvMode
sdc/PortExtCap.cc:                       #include "NetworkClass.hh" for sta::Port
util/ReportTcl.cc:                       #include "Report.hh" for sta::Report
util/RiseFallMinMaxDelay.cc:             #include "StaState.hh" for sta::StaState
util/RiseFallMinMax.cc:                  #include "Transition.hh" for sta::RiseFallBoth
util/RiseFallValues.cc:                  #include "Transition.hh" for sta::RiseFallBoth
sdc/PortExtCap.cc:                       #include "MinMax.hh" for sta::MinMax
util/RiseFallMinMaxDelay.cc:             #include "MinMax.hh" for sta::MinMax
dcalc/DelayNormal.cc:                    #include "Delay.hh" for sta::Delay
dcalc/DelayScalar.cc:                    #include "Delay.hh" for sta::Delay
dcalc/DelaySkewNormal.cc:                #include "Delay.hh" for sta::Delay
util/RiseFallMinMaxDelay.cc:             #include "Delay.hh" for sta::Delay
dcalc/Delay.cc:                          #include "MinMax.hh" for sta::EarlyLate
dcalc/DelayNormal.cc:                    #include "MinMax.hh" for sta::EarlyLate
dcalc/DelayScalar.cc:                    #include "MinMax.hh" for sta::EarlyLate
dcalc/DelaySkewNormal.cc:                #include "MinMax.hh" for sta::EarlyLate
sdc/PortExtCap.cc:                       #include "Transition.hh" for sta::RiseFall
util/RiseFallMinMaxDelay.cc:             #include "Transition.hh" for sta::RiseFall
util/MinMax.cc:                          #include <array> for std::array
util/Transition.cc:                      #include <array> for std::array
power/VcdParse.cc:                       #include <stdexcept> for std::invalid_argument
dcalc/FindRoot.cc:                       #include <utility> for std::pair
util/StringUtil.cc:                      #include <utility> for std::pair
dcalc/Delay.cc:                          #include <string> for std::string
dcalc/DelayNormal.cc:                    #include <string> for std::string
dcalc/DelayScalar.cc:                    #include <string> for std::string
dcalc/DelaySkewNormal.cc:                #include <string> for std::string
liberty/Units.cc:                        #include <string> for std::string
network/VerilogNamespace.cc:             #include <string> for std::string
power/VcdParse.cc:                       #include <string> for std::string
search/PocvMode.cc:                      #include <string> for std::string
util/Error.cc:                           #include <string> for std::string
util/PatternMatch.cc:                    #include <string> for std::string
util/Report.cc:                          #include <string> for std::string
util/StringUtil.cc:                      #include <string> for std::string
util/Transition.cc:                      #include <string> for std::string
dcalc/ArnoldiDelayCalc.cc:               #include "Error.hh" for criticalError
search/GatedClk.cc:                      #include "Error.hh" for criticalError
search/Levelize.cc:                      #include "Error.hh" for criticalError
util/Report.cc:                          #include <cstdio> for printf
util/MachineWin32.cc:                    #include <cstdarg> for va_list
```

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller force-pushed the feature-20260414-fix-missing-inc branch from 9d9f5b1 to 98bdb02 Compare April 14, 2026 10:54
@hzeller
Copy link
Copy Markdown
Contributor Author

hzeller commented Apr 14, 2026

I have scripts to fix more of these, but I'd need the clang-format to help sorting the headers afterwards. However, right now, clang-format would create a huge churn, so I leave this to after that has been run before.

@parallaxsw
Copy link
Copy Markdown
Owner

The reason the commit was called round1 is because I am in the process of doing this.
This PR does not help, it only creates conflicts.

@parallaxsw parallaxsw closed this Apr 14, 2026
@hzeller
Copy link
Copy Markdown
Contributor Author

hzeller commented Apr 14, 2026

Sorry, I was mostly excited to see the addition of a .clang-tidy file and tried out if my scripts to fix some misc-include-cleaner work.

@parallaxsw
Copy link
Copy Markdown
Owner

You can pretty much bet on the fact that I will reject any PR that changes more than a few files without some sort of planning before it appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants